Closed
Bug 766639
Opened 12 years ago
Closed 12 years ago
remove erroneous and unused line in run_tests.py
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
Details
Attachments
(1 file)
|
811 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/build/talos/file/9260443c2e98/talos/run_tests.py#l184 For one, this should reference results_urls not result_url. However this variable isn't used at all and is in fact overwritten at http://hg.mozilla.org/build/talos/file/9260443c2e98/talos/run_tests.py#l273 This line should just be removed
|
Reporter | |
Comment 1•12 years ago
|
||
I should have caught this for bug 755527....but i didn't. Its harmless just stupid
|
|
Reporter | |
Comment 2•12 years ago
|
||
Attachment #634979 -
Flags: review?(jmaher)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 634979 [details] [diff] [review] remove this line Review of attachment 634979 [details] [diff] [review]: ----------------------------------------------------------------- please stop the influx of large patch reviews!
Attachment #634979 -
Flags: review?(jmaher) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
pushed: http://hg.mozilla.org/build/talos/rev/cb3483394ee4 thanks for the quick review
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Comment 5•12 years ago
|
||
Try run for bde75288f7b0 is complete.
Detailed breakdown of the results available here:
https://tbpl.mozilla.org/?tree=Try&rev=bde75288f7b0
Results (out of 91 total builds):
success: 87
failure: 4
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jhammel@mozilla.com-bde75288f7b0
You need to log in
before you can comment on or make changes to this bug.
Description
•