766699 - When profile edit/create causes a validation error, show the (first) tab with an error

Status: VERIFIED WONTFIX

(Participation Infrastructure :: Phonebook, defect)

Description

[Aakash Desai [:aakashd]]

Steps to Reproduce:
1. Go to the Edit Profile page
2. Click on the "Account" tab
3. Change the username to an already used username
4. Click on update.

Actual Results:
Nothing is saved, but the "Profile" tab is shown.

Expected Results:
Nothing is saved and the "Account" tab is still shown.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

This happens for other errors, too -- for example, if a user fails to check the privacy policy optin box, they are returned to the Profile tab. The fix should be to display the (first) tab where an error occurs.

Comment 2

[John Kim [snoozes]]

Assignee: [e-mail] -> [e-mail]
Status: NEW -> ASSIGNED

Comment 3

[John Kim [snoozes]]

Sorry but how do one assign a bug to themselves?

Comment 4

[John Kim [snoozes]]

Hello.
I submitted my first pull request for the following fixes:
  1. Edit Profile
  2. Register
Is this fix okay or does it need further improvements?
Thank you.

Comment 5

[Justin Crawford [:hoosteeno] [:jcrawford]]

Thank you for your PR! We haven't had a chance to review but once we do we'll reply in the PR with any comments.

Comment 6

[Justin Crawford [:hoosteeno] [:jcrawford]]

John, I emailed you separately about this. I'm very sorry for the confusion.

I'm removing the [good first bug] tag from this bug and WONTFIXING it. It will be addressed as part of the UI overhaul currently underway in bug 867267. See https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.community-tools/h46g0AD117M for more info.

Comment 7

[Matt Brandt [:mbrandt]]

QA verified wontfix per the upcoming UI overhaul