76671 - Rejecting sgml mimetypes at view source

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Sorin Banu]

There is for sure that sgml mimetype is supported if someone had clicked view 
source on it. It cannot ask for source on an unloaded document.
Thats why I am asking you to check in this one-line patch that allows others 
developers to use your view-source components. In this case, this is about 
DocZilla that supports SGML files.

Thanx!
sorinb

Comment 1

[Sorin Banu]

Attachment: Patch for BUG 76671. Diff done in mozilla/htmlparser/src folder.

Comment 2

[Keyser Sose]

Marking NEW so the patch will get looked at...adding cc: bz because hes been
working on View Source lately.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sorin, thanks for the patch.  A nitpick.  Please look at the way the other MIME
types are handled.  You probably want to define kSGMLContentType in the same way
and use it in the EqualsWithConversion. (See
http://lxr.mozilla.org/seamonkey/source/htmlparser/src/nsIParser.h#353 in
particular.)

Do you have a link to a text/sgml file that this could be tested on?

Comment 4

[Sorin Banu]

Attachment: Same patch, just added the type defining and used it.

Comment 5

[Sorin Banu]

This is the new patch including the kSGMLTextContentType defining in 
nsIParser.h. In network/mime/public/nsMimeTypes.h file there are defined this 
types again, and I had it defined there first.
About a sgml file that this could be tested on, I could give you one, but 
Mozilla doesnt support SGML files... so you cannot reach to that point where 
you can view source. DocZilla can view them, but you have only the release 
version. Anyway... this patch it is not some big deal and i can ensure you it 
works.

sorinb

Comment 6

[Boris Zbarsky [:bzbarsky]]

Looks good to me, and looks like it should do the right thing...  reviews?

Comment 7

[Boris Zbarsky [:bzbarsky]]

adding dependency on the bug about showing source for generic text/* files.

Comment 8

[Sorin Banu]

But can't it be patched with this patch for m 0.9? Nobody knows when m 1.0 will 
be out and till then will be released a new version of DocZilla, for example, 
based on 0.9... and we will have to modify this in Mozilla in order to have the 
view-source and make gkparser.dll DocZilla specific, for one single modified 
line.
I understood the dependency on bug 77337, but until 1.0 it can be added this 
patch in order to have view-source for sgml.
Thanx in advance!

Comment 9

[harishd]

May be we can shoot this for m0.9.1.

Comment 10

[harishd]

The patch looks good. r=harishd

Comment 11

[Johnny Stenback (:jst)]

sr=jst

Comment 12

[Keyser Sose]

This was checked in earlier today. Marking FIXED.

Comment 13

[bsharma]

Marking verified as per above developer comments.