nsNodeInfoManager needs to be able to add itself to the purple buffer

RESOLVED FIXED in mozilla16

Status

()

Product:
Core
Component:
XPCOM
Type:
defect
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
7 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

Version:
unspecified
Target:
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch
5.97 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Posted patch patch — — Splinter Review 
This is similar to bug 750424, but for nsNodeInfoManager. This was causing intermittent leaks with the patches in bug 758034 applied. With this patch, the leaks are gone.
Attachment #635067 - Flags: review?(bugs)
Comment on attachment 635067 [details] [diff] [review]
patch


>+NS_IMPL_CYCLE_COLLECTING_ADDREF(nsNodeInfoManager)
>+NS_IMPL_CYCLE_COLLECTING_RELEASE(nsNodeInfoManager)
>+
>+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsNodeInfoManager)
>+    NS_INTERFACE_MAP_ENTRY(nsISupports)
2 space indentation, please
Attachment #635067 - Flags: review?(bugs) → review+
Sorry I haven't fixed bug 750570 yet. :(
https://hg.mozilla.org/mozilla-central/rev/5135641e4496
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 782735
You need to log in before you can comment on or make changes to this bug.