Closed
Bug 766717
Opened 10 years ago
Closed 10 years ago
nsNodeInfoManager needs to be able to add itself to the purple buffer
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
5.97 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This is similar to bug 750424, but for nsNodeInfoManager. This was causing intermittent leaks with the patches in bug 758034 applied. With this patch, the leaks are gone.
Attachment #635067 -
Flags: review?(bugs)
Comment 1•10 years ago
|
||
Comment on attachment 635067 [details] [diff] [review] patch >+NS_IMPL_CYCLE_COLLECTING_ADDREF(nsNodeInfoManager) >+NS_IMPL_CYCLE_COLLECTING_RELEASE(nsNodeInfoManager) >+ >+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsNodeInfoManager) >+ NS_INTERFACE_MAP_ENTRY(nsISupports) 2 space indentation, please
Attachment #635067 -
Flags: review?(bugs) → review+
Comment 2•10 years ago
|
||
Sorry I haven't fixed bug 750570 yet. :(
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5135641e4496
Target Milestone: --- → mozilla16
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5135641e4496
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•