endRunner is never called for user restart tests

RESOLVED FIXED

Status

Testing Graveyard
Mozmill
--
major
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

({dataloss})

unspecified
dataloss
Bug Flags:
in-testsuite +

Details

(Whiteboard: [mozmill-2.0+])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
For user restart tests we never call Runner.end() which causes us not to sync the persisted data, stop the httpd server and send the 'endRunner' event. 

The most serious issue here is the persisted case because a followup test doesn't have access to any value set in the first test.

So should make sure that in case of userShutdown requests we successfully sync any data and quit safely.
(Assignee)

Comment 1

6 years ago
Created attachment 635083 [details]
Patch

Pointer to Github pull-request
(Assignee)

Comment 2

6 years ago
Comment on attachment 635083 [details]
Patch

With this patch we ensure to call Runner.end() if an userShutdown request is active and Firefox gets restarted. It doesn't fix the case when the restart fails. This will be part of my fix on bug 765687.
Attachment #635083 - Attachment description: Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/51 → Patch
Attachment #635083 - Flags: review?(jhammel)
(Assignee)

Updated

6 years ago
Blocks: 765687

Updated

6 years ago
Attachment #635083 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

6 years ago
https://github.com/mozautomation/mozmill/commit/f1e5fbaaa13c60669bda47ebf48a906797f22737
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
Whiteboard: [mozmill-2.0+]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.