Show compatibility error if an add-on invokes queryCommandText or execCommandShowHelp

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Compatibility Tools
RESOLVED FIXED
6 years ago
2 years ago

People

(Reporter: jorgev, Assigned: basta)

Tracking

Details

(Whiteboard: [fx14])

(Reporter)

Description

6 years ago
As explained in bug 742261, queryCommandText and execCommandShowHelp have been removed from nsIDOMHTMLDocument. We need to flag all instances of these methods and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The queryCommandText and execCommandShowHelp functions have been removed from the nsIDOMHTMLDocument interface. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=742261

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/firebug/
(Assignee)

Comment 2

6 years ago
Merged:

https://github.com/mozilla/amo-validator/commit/86d06cfabca5ede6ca0d5da072a5851bffde65be
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 3

6 years ago
> Affected add-on:
> 
> https://addons.mozilla.org/en-US/firefox/addon/firebug/

Jorge, basta tells me that firebug doesn't use these flagged methods in a way which would fail compatibility.

Are you aware of any other add-ons which do? mxr wasn't very helpful.
(Reporter)

Comment 4

6 years ago
I only found Firebug-related add-ons that do this. If that code doesn't cause any compat problems, there's nothing else that needs testing.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.