766781 - Show compatibility warning if an add-on uses nsILocalFile

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[Jorge Villalobos [:jorgev] (he/him)]

As explained in bug 682360, nsILocalFile no longer serves any purpose and might be deprecated in the future. We need to flag all instances of this interface and show a warning.

This is a compatibility warning, so the add-on should still be upgraded in this case.

Message:

Starting with Firefox 14, nsILocalFile inherits all functions and attributes from nsIFile, meaning that you no longer need to use nsILocalFile. If your add-on doesn't support versions older than 14, you should use nsIFile instead of nsILocalFile. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=682360

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/chatzilla/ (and many others).

Comment 1

[Matt Basta [:basta]]

Since nsILocalFile is going away, are we removing the test for `nsILocalFile.launch()`?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

We should actually extend it to include nsIFile.launch() as well. nsILocalFile will continue to exist for the foreseen future.

Comment 3

[Kris Maglione [:kmag]]

We should probably move it to nsIFile.launch and add inheritance information for all interfaces that we have checks for. I can probably write a script to do that.

Comment 4

[Matt Basta [:basta]]

Pull request:

https://github.com/mozilla/amo-validator/pull/161

Comment 5

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/amo-validator/commit/86d06cfabca5ede6ca0d5da072a5851bffde65be

Comment 6

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/developers/upload/78c2c3e597f241a288c14a6c609e4fa9