The default bug view has changed. See this FAQ.

nsBulletFrame::mComputedSize is unnecessary

RESOLVED FIXED in mozilla16

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 635123 [details] [diff] [review]
fix v1 (remove member var)

Just noticed that nsBulletFrame currently has a member variable "mComputedSize" which is unnecessary.

We only use it in one place, and we set its value and then read that value back-to-back in that place.  (I believe this has basically been the case since this variable was added in bug 78690.)

Attached patch just removes the variable altogether.
Attachment #635123 - Flags: review?(matspal)
(Assignee)

Updated

5 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 635123 [details] [diff] [review]
fix v1 (remove member var)

Good catch!
Attachment #635123 - Flags: review?(matspal) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/42c652ac08c8
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/42c652ac08c8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.