Closed Bug 766834 Opened 10 years ago Closed 10 years ago

TB-IM Status tooltips not updated for chats without status

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(thunderbird15 fixed, thunderbird16 fixed)

RESOLVED FIXED
Thunderbird 17.0
Tracking Status
thunderbird15 --- fixed
thunderbird16 --- fixed

People

(Reporter: Mook, Assigned: mconley)

Details

Attachments

(1 file, 1 obsolete file)

STR:
1. Open a chat with somebody with a status (e.g. #developers on irc.m.o, where the status is the channel topic)
2. Open a chat with somebody without a status (e.g. NickServ on irc.m.o) in the same window/tab
3. Hover the mouse cursor over the "Unknown" status, below the contact name

Expected results:
No tooltip, or a tooltip saying "Status unknown", or something

Actual results:
A tooltip shows, containing the status of the last displayed conversation that had one (in this case, the topic for #developers)

Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Thunderbird/16.0a1 20120620030201
Assignee: nobody → mconley
Attached patch Patch v1 (obsolete) — Splinter Review
I opted to make the tooltip visible in all cases, for consistencies sake.
Attachment #643950 - Flags: review?(florian)
Comment on attachment 643950 [details] [diff] [review]
Patch v1

Seems good.
Attachment #643950 - Flags: review?(florian)
Attachment #643950 - Flags: review+
Attachment #643950 - Flags: approval-comm-beta?
Attachment #643950 - Flags: approval-comm-aurora?
(In reply to Florian Quèze from comment #2)
> Comment on attachment 643950 [details] [diff] [review]
> Patch v1
> 
> Seems good.

Looked at this again while reviewing bug 772773. Is it expected that the status tooltip is displayed while hovering the "is typing" or "has stopped typing" message?
(In reply to Florian Quèze from comment #3)
> (In reply to Florian Quèze from comment #2)
> > Comment on attachment 643950 [details] [diff] [review]
> > Patch v1
> > 
> > Seems good.
> 
> Looked at this again while reviewing bug 772773. Is it expected that the
> status tooltip is displayed while hovering the "is typing" or "has stopped
> typing" message?

It's probably OK - consistency is good - I'd rather do that then display tooltips only sometimes.
Wouldn't you expect "<display name> is typing" in the tooltip?
(In reply to Florian Quèze from comment #5)
> Wouldn't you expect "<display name> is typing" in the tooltip?

Isn't that what it's displaying?

If not, then yes, something is wrong.
It displays the contact's status (in the case I tested it displayed "Idle - test").
(In reply to Florian Quèze from comment #7)
> It displays the contact's status (in the case I tested it displayed "Idle -
> test").

Yep, that's not right.
Comment on attachment 643950 [details] [diff] [review]
Patch v1

Clearing these flags, due to the post-review issue that Florian found.
Attachment #643950 - Flags: review+
Attachment #643950 - Flags: approval-comm-beta?
Attachment #643950 - Flags: approval-comm-aurora?
Attached patch Patch v2Splinter Review
Florian:

Ok, now when the contact is typing, the tooltip reads "[name] is typing", when they've stopped, "[name] has stopped typing".

-Mike
Attachment #643950 - Attachment is obsolete: true
Attachment #644352 - Flags: review?(florian)
Attachment #644352 - Flags: review?(florian)
Attachment #644352 - Flags: review+
Attachment #644352 - Flags: approval-comm-beta?
Attachment #644352 - Flags: approval-comm-aurora?
Comment on attachment 644352 [details] [diff] [review]
Patch v2

Yeah, I really think we want to have this on aurora/beta.
Attachment #644352 - Flags: approval-comm-beta?
Attachment #644352 - Flags: approval-comm-beta+
Attachment #644352 - Flags: approval-comm-aurora?
Attachment #644352 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/a7b28a555957
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/9ae2aa7edbc0
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/4275bc483518
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/716a3a38c313
You need to log in before you can comment on or make changes to this bug.