76689 - non-ASCII xml end tag in view source display as comment

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Frank Tang]

Reproduce procedure
1. view a xml which use non-ASCII (say greek) as element
2. xml display correctly
3. select "view:view source"
expect result
see the xml as the source
actual result
everything else looks fine (if the encoding="" is present in the <?xml ...> )
but the end tag always display as comment
<!XXX>

Comment 1

[Frank Tang]

Attachment: chinese xml page

Comment 2

[Frank Tang]

What happen is we use expat as xml tokenizer but use nsHTMLTokenizer for
xml view source. and in the nsHTMLTokenizer, we assume all the tag name in the 
end tag should be in ASCII alpha- which is not the case for xml.

talk to harishd and decide to change the logic to the folllowing
the origional logic
if we get a '<' and a '/' and the next char is ascii alpha or '>' , consume it 
as end tag, otherwise, consume it as comment tag
new logic
do the same thing for html , but for xml and xhtml, also consume it as end tag 
if the next char is not ascii

Comment 3

[Frank Tang]

Attachment: patch

Comment 4

[Frank Tang]

harisd- can you review this patch as module owner?

Comment 5

[Frank Tang]

r=harishd 3 weeks ago. 
mark it as assigned. 
blizzard - can you sr this one?

Comment 6

[Frank Tang]

somehow the xml view source us html tokenizer and it assume the tag have to be in 
ASCII. Howerver, in XML all the element could be in non ascii base characters. 

Comment 7

[Frank Tang]

request for sr after harishd review two weeks ago.

Comment 8

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 9

[Frank Tang]

fix and check in 

Comment 10

[Boris Zbarsky [:bzbarsky]]

*** Bug 79800 has been marked as a duplicate of this bug. ***

Comment 11

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 12

[Teruko Kobayashi]

Verified as fixed in 5-11-08 Win32, Linux, and Mac build.

Comment 13

[Heikki Toivonen (remove -bugzilla when emailing directly)]

SPAM. HTML Element component deprecated, changing component to Layout. See bug
88132 for details.