766934 - Move feedback button to header on main page

Status: VERIFIED FIXED

(Pancake Graveyard :: Native iOS Wrapper, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Move feedback button to header on main page.

Comment 1

[Wilson Guaraca]

Hey all,
Stefan, thank you for opening this bug. I really like your idea of combining the pancake logo on the left with the feedback button. We just have to make sure this button is subtle and visible. 

But if we just want to keep it simple we should just add the feedback button on the right side of the header. 

I have added Stuart to the bug. 

Best,
Wilson

Comment 2

[Deb Richardson [:dria] (plz NEEDINFO)]

I'm not sure I understand what's wanted here -- do we want to turn the Pancake logo that's currently in the header into a button that will bring up a feedback panel or something?

Do we have a design for this yet?

Comment 3

[Deb Richardson [:dria] (plz NEEDINFO)]

Also is this something we want for M3?

Comment 4

[Ian Barlow (:ibarlow)]

I think the logo and feedback button should be separate things. I'll post a mockup soon.

Comment 5

[Wilson Guaraca]

Deb, welcome back! I suggested to the team that we add a feedback button because the button is so hidden in the current version of pancake. 

Stuart, how quickly can we implement this button?

Ian, thank you for working on the mockup!

Comment 6

[Stuart Parmenter]

We need this before we can submit to the app store, so need to get graphics today if possible

Comment 7

[Ian Barlow (:ibarlow)]

Here is a mockup http://cl.ly/172g3g0Z0c473F0f2Z1P

and here are the required button assets: http://cl.ly/2w391H2H3Z083H0F1K0P

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed with the following changes;

https://bitbucket.org/mozillapancake/pancake-ios/changeset/a38dae1d4a3f
https://bitbucket.org/mozillapancake/pancake/changeset/6dda770ca4a3
https://bitbucket.org/mozillapancake/pancake/changeset/da430d157ed9

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Also https://bitbucket.org/mozillapancake/pancake-ios/changeset/ef11bce6739e

Button font and positioning tweaks.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Also https://bitbucket.org/mozillapancake/pancake-ios/changeset/a4cbbc5b9b50

(Use username part of email address as the display name for UserVoice.)

Comment 11

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Also https://bitbucket.org/mozillapancake/pancake/changeset/95114aa38374

Removed code that was not needed.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

verified 6/26/2012 Dev