767065 - Text selection handles remain after selection is programatically collapsed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Eitan Isaacson [:eeejay]]

Attachment: Test case

STR:
1. Load given file.
2. Select a word via long text.
3. After a few seconds selection is collapsed.
4. Handles awkwardly remain, with no highlighted text in between them.

Expected result: Handles should go away along with selection.

Comment 1

[:Margaret Leibovic]

Attachment: patch

I was running into a problem where a normal endSelection call was clearing the selection, then my listener was firing and calling endSelection again. I tried fixing this by checking _active in the listener, but that didn't work because _active was being flipped at the bottom of the method. To fix this we should flip _active at the beginning of endSelection, and we never want to be executing the rest of this method if there's no active selection, so I added a check to bail.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d095c0213dc8

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d095c0213dc8

Comment 4

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6