Text selection handles remain after selection is programatically collapsed

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
Text Selection
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: eeejay, Assigned: Margaret)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified, firefox16 verified, firefox17 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 635385 [details]
Test case

STR:
1. Load given file.
2. Select a word via long text.
3. After a few seconds selection is collapsed.
4. Handles awkwardly remain, with no highlighted text in between them.

Expected result: Handles should go away along with selection.

Updated

6 years ago
OS: Linux → Android
Hardware: x86_64 → ARM
(Assignee)

Updated

6 years ago
Blocks: 695173
(Assignee)

Comment 1

6 years ago
Created attachment 636853 [details] [diff] [review]
patch

I was running into a problem where a normal endSelection call was clearing the selection, then my listener was firing and calling endSelection again. I tried fixing this by checking _active in the listener, but that didn't work because _active was being flipped at the bottom of the method. To fix this we should flip _active at the beginning of endSelection, and we never want to be executing the rest of this method if there's no active selection, so I added a check to bail.
Assignee: nobody → margaret.leibovic
Attachment #636853 - Flags: review?(mbrubeck)
Attachment #636853 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d095c0213dc8
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/d095c0213dc8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

6 years ago
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Component: General → Text Selection

Updated

6 years ago
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified
You need to log in before you can comment on or make changes to this bug.