Closed Bug 767162 Opened 8 years ago Closed 8 years ago

New Australis tab design doesn't respect standalone message window

Categories

(Thunderbird :: Toolbars and Tabs, defect)

x86
macOS
defect
Not set
normal

Tracking

(thunderbird15 fixed)

RESOLVED FIXED
Thunderbird 16.0
Tracking Status
thunderbird15 --- fixed

People

(Reporter: Nomis101, Assigned: Paenglab)

References

Details

Attachments

(2 files)

Bug 763308 has made the tabs looking good, but now the standalone message window looks strange.
Attached patch patchSplinter Review
Move the rule from primaryToolbar.css to mailWindow1.css to only work in main window.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #636041 - Flags: review?(mconley)
Comment on attachment 636041 [details] [diff] [review]
patch

stealing this from Mike to ease his post-vacation trauma :)
Attachment #636041 - Flags: review?(mconley) → review?(nisses.mail)
Comment on attachment 636041 [details] [diff] [review]
patch

Works as expected and is just moving code from one file to another, so r+=me
Attachment #636041 - Flags: review?(nisses.mail) → review+
Keywords: checkin-needed
Comment on attachment 636041 [details] [diff] [review]
patch

[Approval Request Comment]
If Bug 763308 becomes approval then this patch should also becoming it to solve the issue on standalone window.
Attachment #636041 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/2fffa32b055e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Due to test failures from bug 755793 landing, I had to back this out:

https://hg.mozilla.org/comm-central/rev/b7dd4a4421e4
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Asking again for check-in as this patch shouldn't be cause of the failures.
Keywords: checkin-needed
I'm unable to reproduce those failures locally.  I've pushed both this and bug 766793 to try, just in case.

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=140b51b72e6c
Hm, those failures are showing up in the try build. Curious.
https://hg.mozilla.org/comm-central/rev/9c5bb38d9a0c
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #636041 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.