If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

SaveAs->file|Template menu items don't work on standalone win

VERIFIED FIXED in mozilla0.9.1

Status

MailNews Core
Composition
P2
major
VERIFIED FIXED
17 years ago
9 years ago

People

(Reporter: Sheela Ravindran, Assigned: Sean Su)

Tracking

Trunk
mozilla0.9.1
x86
All

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta1+]Have Fix)

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
Buildid:  2001-04-19-08 linux and mac

steps to reproduce:
Double click an existing message to open to a stand alone window
Go to Menu item File|Save As

Expected: Both file|template should be enabled and should let you save as file 
or template

Actual: Both file|template menu items are disabled and does not let the user 
save as file or template an existing message from the stand alone window.

But these menu items are enabled from the 3 pane. Disable only from standalone 
window.
(Reporter)

Comment 1

17 years ago
change qa contact, add keywords. Could be a regression. I was able to save as 
file or template from a standalone window in previous builds.
Keywords: nsbeta1
QA Contact: esther → sheelar
(Reporter)

Comment 2

17 years ago
More information...   When you double click a message from inbox, sent, or any 
user created folders both pop and imap is when the above menu items are 
disabled.  But these menu item are available in a standalone window for messages 
opened from drafts,templates folders both imap and pop. 

Comment 3

17 years ago
Drafts and templates shouldn't open up a standalone window.

This isn't happening to me on Windows.  Is this still happening on Linux and Mac
for you?  Are there other menuitems that aren't working?
(Reporter)

Comment 4

17 years ago
Messages opened from drafts and templates folder are in edit mode and can be 
saved. 
Problem is with other folders like inbox,or user defined folder.  In 4.x when 
you double click on an existing message from inbox it opens in a stand alone 
window and you can save as file/template.

In today's build the menu items are enabled but perform no action. Should this 
be a new bug? 

Comment 5

17 years ago
sorry, I was looking for them to be disabled.  But you are right that they don't
work but do work in 3 pane.  reassigning to ssu for nsbeta1+
Assignee: ducarroz → ssu
Priority: -- → P2
Summary: SaveAs->file|Template menu items disabled on standalone win → SaveAs->file|Template menu items don't work on standalone win
Whiteboard: [nsbeta1+]
Target Milestone: --- → mozilla0.9.1
(Assignee)

Comment 6

17 years ago
I have a fix for this.  However, the SaveAs|File and SaveAs|Template menu items 
will be disabled until the body of the message is clicked.  This is bug 76745.  
When these menu items are enabled, my patch will work.
Status: NEW → ASSIGNED
(Assignee)

Comment 7

17 years ago
Created attachment 32393 [details] [diff] [review]
patch attempt #1
cc'ing varada who should be the reviewer.

Comment 9

17 years ago
reviewed and tested the patch.
r=varada

Updated

17 years ago
Whiteboard: [nsbeta1+] → [nsbeta1+]Have Fix
no go on that patch.

there's a better (cleaner) way to fix this.

reimplement MsgSaveAsTemplate() and MsgSaveAsFile() to use
GetNumSelectedMessages() and GetFirstSelectedMessage().  those are defined to do
the right thing in messageWindow.js and msgMail3PaneWindow.js

something like:

function MsgSaveAsTemplate()
{
 var folder = GetLoadedMsgFolder();
 if (GetNumSelectedMessages() == 1) {
   SaveAsTemplate(GetFirstSelectedMessage(), folder);
 }
}

(Assignee)

Comment 11

17 years ago
Created attachment 32628 [details] [diff] [review]
patch #2 done with Seth's suggestion.

Comment 12

17 years ago
reviewed and tested the new patch.
r=varada
sr=sspitzer

we might have similar bugs with similar fixes lurking in mailWindowOverlay.js 
(or other files).

if you have the cycles, you could see what looks fishy or scan bugzilla for 
some stand alone msg window only problems. 


(Assignee)

Comment 14

17 years ago
will do Seth.  Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 15

17 years ago
verified:
win98-2001050706 
linux-2001050708
mac-2001050209
Status: RESOLVED → VERIFIED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.