767347 - OOM sqlite crash in mozalloc_abort

Status: RESOLVED INCOMPLETE

(MailNews Core :: Search, defect)

Description

[Wayne Mery (:wsmwk)]

This bug was filed from the Socorro interface and is 
report bp-8f9df17a-e4a6-43dc-b9fb-078892120618 .
============================================================= 

regression starting in version 12.
v12 bp-85fc57ef-2540-4a16-a7f3-82eff2120518
v12.0.1 bp-ff28467a-361e-427a-ac7b-99ce62120530
rare - 24 crashes in 2 weeks.
slightly over 50% are startup

bp-8f9df17a-e4a6-43dc-b9fb-078892120618 version 14
0	mozalloc.dll	mozalloc_abort	memory/mozalloc/mozalloc_abort.cpp:79
1	mozalloc.dll	mozalloc_handle_oom	memory/mozalloc/mozalloc_oom.cpp:60
2	mozalloc.dll	moz_xmalloc	memory/mozalloc/mozalloc.cpp:89
3	xul.dll	mozilla::storage::Row::initialize	storage/src/mozStorageRow.cpp:69
4	xul.dll	mozilla::storage::AsyncExecuteStatements::buildAndNotifyResults	storage/src/mozStorageAsyncStatementExecution.cpp:434
5	xul.dll	mozilla::storage::AsyncExecuteStatements::executeAndProcessStatement	storage/src/mozStorageAsyncStatementExecution.cpp:343
6	xul.dll	mozilla::storage::AsyncExecuteStatements::Run	storage/src/mozStorageAsyncStatementExecution.cpp:651
7	xul.dll	nsThread::ProcessNextEvent	xpcom/threads/nsThread.cpp:656 

and signature mozilla::storage::AsyncExecuteStatements::buildAndNotifyResults(sqlite3_stmt*) eg bp-e3e1ed63-3ece-4c8b-949e-e732d2120618

Comment 1

[Jonathan Protzenko [:protz]]

Andrew, could it be that one of the big queries we're doing when upgrading the database makes Thunderbird OOM?

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I wouldn't infer anything from only 24 data-points on an out-of-memory crash where the allocation is something small, as it is in this case (a string).  It's just the straw the breaks the camel's back.  (We could infer something based on how many times it's the straw the breaks the back, but not on 24 instances.)

Comment 3

[Wayne Mery (:wsmwk)]

I suspect in version 31 the sig is [@ mozilla::storage::Row::initialize(sqlite3_stmt*) ]
eg bp-490fae30-3dbd-4039-9d41-16fde2150122

But with only 3 crashes in one month it's not worth keeping the bug open nor putting effort to finding a fix, unless there's something terribly obvious to fix.