Closed Bug 767389 Opened 9 years ago Closed 9 years ago

about:home and about:newtab are intermittently shown in the Debugger dropdown

Categories

(DevTools :: Debugger, defect, P2)

15 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 16

People

(Reporter: ioana_damy, Assigned: vporof)

Details

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Launch Firefox with a fresh profile.
2. Open the Debugger (Tools->Web developer->Debugger, or press Ctrl+Shift+S) on about:home or about:newtab.

about:home and about:newtab are sometimes shown in the Debugger dropdown. I have only seen about:newtab once or twice in the dropdown until now, but about:home is displayed somewhat more often.
This is to be expected, but a fix is quite necessary nonetheless.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch v1 (obsolete) — Splinter Review
Attachment #638669 - Flags: review?(past)
Comment on attachment 638669 [details] [diff] [review]
v1

Review of attachment 638669 [details] [diff] [review]:
-----------------------------------------------------------------

That's the wrong place to check for the protocol, because it leaves an about:home script in the script list and a dangling "Loading..." message in the editor. See TA__addScript (script actors) for the existing chrome protocol check.
Attachment #638669 - Flags: review?(past) → review-
Attached patch v1Splinter Review
Attachment #638669 - Attachment is obsolete: true
Attachment #642341 - Flags: review?(past)
Attachment #642341 - Flags: review?(past) → review+
Whiteboard: [land-in-fx-team]
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/206b75c9d58e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.