When navigating between web pages with the Back and Forward buttons, the same scripts are displayed in the Debugger for all the pages

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ioana (away), Assigned: past)

Tracking

15 Branch
Firefox 16
Points:
---

Firefox Tracking Flags

(firefox15 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20120621 Firefox/15.0a2 (20120621042006)

STR:
1. Load any web page with JSs in the browser.
2. Open the Debugger (Tools->Web developer->Debugger, or press Ctrl+Shift+S).
3. Load another web page in the same tab. Notice that the scripts dropdown gets updated accordingly.
4. Click on the Back button.

The scripts dropdown doesn't get updated at step 4. When navigating between web pages with the Back and Forward buttons, the scripts from the page loaded last in the browser are displayed in the Debugger for all the pages.
Hmm, I can trigger this if I additionally click the Forward button after step 4.

Tested with
http://htmlpad.org/debugger/
then
http://astithas.com/test/bp/index.html

Panos?
In Nightly I see the behavior Victor describes in comment 1. I haven't tested with Aurora to see if I can reproduce Ioana's symptoms. The problem is that forward (and maybe back) doesn't seem to trigger a DOMWindowCreated event, which hoses our navigation logic.
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P2
Created attachment 639709 [details] [diff] [review]
Working patch

Adding a pageshow handler fixes this.
Attachment #639709 - Flags: review?(rcampbell)
Try run: https://tbpl.mozilla.org/?tree=Try&rev=464187506b3c
Comment on attachment 639709 [details] [diff] [review]
Working patch

looks good.
Attachment #639709 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/cb7d40a84ae3
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/cb7d40a84ae3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 16
Comment on attachment 639709 [details] [diff] [review]
Working patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: developers would have to reload the page after going back or forward in history, in order for the debugger to display the actual page contents
Testing completed (on m-c, etc.): On m-c and fx-team
Risk to taking this patch (and alternatives if risky): pretty trivial patch, minor risk
String or UUID changes made by this patch: none
Attachment #639709 - Flags: approval-mozilla-aurora?

Comment 9

5 years ago
Comment on attachment 639709 [details] [diff] [review]
Working patch

[Triage Comment]
New feature, developer focused release, and low risk. Approved for Aurora 15. Please land ASAP to make it in before Monday's merge.
Attachment #639709 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/7e36c6397b89
status-firefox15: --- → fixed

Updated

5 years ago
Depends on: 774619
(Reporter)

Comment 11

5 years ago
Verified as fixed on:
Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/20100101 Firefox/15.0
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0
status-firefox15: fixed → verified
You need to log in before you can comment on or make changes to this bug.