767413 - Apply clearfix CSS

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Aakash Desai [:aakashd]]

We're using div.clear and shouldn't be. Follow up from comments in pull request 263.

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

I think the fix here is to replace all <div class="clear"> with <div class="ui-helper-clearfix">. The latter class is a true clearfix.

Here's a list (probably not complete) of places where the clear class is used:

(venv)mozillians$ egrep -r 'class="clear"' *

apps/phonebook/templates/phonebook/includes/search_result.html:    <div class="clear"></div>

apps/phonebook/templates/phonebook/profile.html:  <div class="clear"></div>

templates/404.html:  <div class="clear"></div>

templates/500.html:  <div class="clear"></div>

vendor/src/django/django/contrib/admin/templates/admin/actions.html:        <span class="clear"><a href="javascript:;">{% trans "Clear selection" %}</a></span>

vendor/src/django/django/contrib/admin/templates/admin/base.html:        <br class="clear" />

vendor/src/django/django/contrib/admin/templates/admin/change_list_results.html:   <div class="clear"></div>

vendor/src/django/django/contrib/admin/templates/admin/date_hierarchy.html:</ul><br class="clear" />

venv/src/django/django/contrib/admin/templates/admin/actions.html:        <span class="clear"><a href="javascript:;">{% trans "Clear selection" %}</a></span>

venv/src/django/django/contrib/admin/templates/admin/base.html:        <br class="clear" />

venv/src/django/django/contrib/admin/templates/admin/date_hierarchy.html:</ul><br class="clear" />

Comment 2

[Michał Frontczak [:fxa90id] ♥]

Can I take it? :)

Comment 3

[Justin Crawford [:hoosteeno] [:jcrawford]]

Yes, and thanks for contributing!

Please note: The above list includes a bunch of admin templates (all of the files in vendor/* and venv/*) that do NOT need to be changed. The admin templates aren't even including the CSS file that includes clearfix.

Reach out in irc.mozilla.org #commtools if you need help. It may be a little quiet this week as the core team is away.

Comment 4

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/mozillians/pull/455

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/b168472274b62b002514230345419d3da0289d84
Merge pull request #455 from fxa90id/Bug_767413

[Bug 767413] - Apply clearfix CSS

Comment 6

[Matt Brandt [:mbrandt]]

This has landed on prod - bumping to resolved fixed

Comment 7

[Matt Brandt [:mbrandt]]

QA verified on prod - I see the updated divs on the pages:

<div class="ui-helper-clearfix"></div>