767437 - Android Sync Send Tab strings hard code Sync brand names

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Nick Alexander :nalexander [he/him]]

We have hard-coded the Sync brand name, and the Firefox brand name.  Also, we refer to "Continue Browsing" when we should just say "Back" or similar.

Comment 1

[Richard Newman [:rnewman]]

For clarity: whenever you see the string "Firefox Sync", it should _not_ be branded. "Aurora Sync" would be wrong, so the only issue here is that we hard-code, not that we hard-code the wrong value.

They should use syncBrand.fullName.label. And "Set up" is the verb form.

IMO, these:

<!ENTITY sync.button.setup.label 'Setup Sync'>
<!ENTITY sync.title.redirect.to.setup.label 'Setup Sync to Send Tabs'>
<!ENTITY sync.text.redirect.to.setup.label 'Setup Firefox Sync on your device to send tabs to other devices.'>

should be

  "Set up &syncBrand.shortName.label;"
  "Set up &syncBrand.shortName.label; to send tabs", and
  "Set up &syncBrand.fullName.label; on your device to send tabs to other devices."

With entity names bumped, of course.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #1)
> For clarity: whenever you see the string "Firefox Sync", it should _not_ be
> branded. "Aurora Sync" would be wrong, so the only issue here is that we
> hard-code, not that we hard-code the wrong value.
> 
> They should use syncBrand.fullName.label. And "Set up" is the verb form.

Right you are, this is what I intended.

> With entity names bumped, of course.

I don't understand this.

Comment 3

[Richard Newman [:rnewman]]

Strings are immutable for localization reasons. If you change one, then you must rename the entity.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #3)
> Strings are immutable for localization reasons. If you change one, then you
> must rename the entity.

So, these strings are all in Send Tab, which has never hit a release other than Nightly.  So do these strings need to be renamed or not?  See pull req for details.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #4)

> So, these strings are all in Send Tab, which has never hit a release other
> than Nightly.  So do these strings need to be renamed or not?  See pull req
> for details.

Unless you can verify that none have been localized (by finding the appropriate l10n tool), you must change the names. So generally… just change the names every time you change a string.

Comment 6

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/699ef823e92e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/699ef823e92e

Comment 8

[Andreea Pod]

Verified fixed on:

Build: Firefox 16.0 Beta 2 build 2
Device: Samsung Galaxy Nexus
OS: Android 4.1.1