767460 - On phones, Menus and Doorhangers should not appear while the tabs tray is open.

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Ian Barlow (:ibarlow)]

To avoid seeing shrunken or partially obscured menus and doorhangers, these items should not work while the tabs tray is open. 

1. Tapping the menu button should close the tabs tray and then load the menu
2. Doorhangers should wait until the tabs tray is closed to be displayed
3. Tapping the site id lock should close the tabs tray and then load the identity menu. 

This is also more consistent with how we handle tapping the URL bar while the tray is open. We first close the tray, and then open the awesomescreen.

Comment 2

[Ian Barlow (:ibarlow)]

Anyone have time to work on this?

Comment 3

[:Margaret Leibovic]

I think we should split these issues into separate bugs, and some of them might be good mentor bugs for contributors getting started.

(In reply to Ian Barlow (:ibarlow) from comment #1)

> 1. Tapping the menu button should close the tabs tray and then load the menu

Now that there's a tabs tray menu, this would just be for hardware buttons, right?

> 2. Doorhangers should wait until the tabs tray is closed to be displayed

DoorhangerPopup.updatePopup() is what controls showing the popup, so we could add some logic in there to bail if the tabs tray is open, and then we could call updatePopup() again when we close the tabs tray to see if there are doorhangers we should show (although we'd need to handle the tablet UI here differently).

> 3. Tapping the site id lock should close the tabs tray and then load the
> identity menu. 

It looks like there are a bunch of different places where we decide to close the tabs tray, but I bet we're probably handling that tap event before the lock icon ever knows about it. Sriram would probably know more about this.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

This is no longer an issue with the full screen tab view.