767471 - Report telemetry data for if the MozillaMaintenance service was ever manually uninstalled

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

We have telemetry data for if the MozillaMaintenance service was installed or not, but it would be good to know if it was manually uninstalled or if it was not installed to begin with. 

61% of users have the service installed on Nightly.  This is probably so low because of x64 builds and possibly because of limited user accounts that don't have the service though.   

This bug is to check that.

To do this we need to create a telemetry histogram for UPDATER_SERVICE_MANUALLY_UNINSTALLED.  It should be a boolean histogram with values 1, 0 which correspond with whether or not the MozillaMaintenance service was manually uninstalled.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Tested locally and it reports the values correctly, will test that it doesn't effect updates in any way on Oak.  Based on the code it shouldn't, but will push anyway to be 101% sure.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1'

Updated patch with comment nit from already landed Bug 766833 (was found at merge time)

Comment 3

[Brian R. Bondy [:bbondy]]

Comment on attachment 636160 [details] [diff] [review]
Patch v1'

Review of attachment 636160 [details] [diff] [review]:
-----------------------------------------------------------------

When the service is installed both Attempted and Installed DWORDS are set to 1.  When the service is uninstalled the Attempted DWORD is purposely left behind.  The attempted DWORD is also used to ensure we don't try to re-install the maintenance service on updates by the way.

I tested both the telemetry probe and updates on Oak and it is working correctly.

Comment 4

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/539051fd90c2

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/539051fd90c2