Closed Bug 767575 Opened 12 years ago Closed 12 years ago

Refactor staging/pp configs

Categories

(Release Engineering :: General, defect, P2)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

Details

Attachments

(3 files, 1 obsolete file)

Attached patch [WIP] simplify configs (obsolete) — Splinter Review
Managing slaves is a PITA.
Assignee: nobody → rail
Looks ok in staging. The only production config touched is b2g_production_config.py.
Attachment #637890 - Flags: review?(bhearsum)
Attachment #635914 - Attachment is obsolete: true
Comment on attachment 637890 [details] [diff] [review]
refactored configs

Review of attachment 637890 [details] [diff] [review]:
-----------------------------------------------------------------

This is generally OK. I'm planning to remove slave definitions entirely from the b2g configs (because they totally duplicate the non-b2g ones), but you can leave these changes in this patch.
Attachment #637890 - Flags: review?(bhearsum) → review+
Should we be using deepcopy() instead of copy() ?
Something seems to be missing here:

http://preproduction-master.srv.releng.scl3.mozilla.com:8710/builders/test-masters/builds/4401/steps/mozilla_config_tests/logs/stdio
twisted.trial.unittest.FailTest: Production slaves should be a subset of staging slaves, however the following production slaves are not listed in staging:
bld-centos5-32-vmw-023
bld-centos5-32-vmw-024
bld-centos5-32-vmw-025
bld-centos5-32-vmw-026
bld-centos5-32-vmw-027
bld-centos5-32-vmw-028
bld-centos5-32-vmw-029
bld-centos5-32-vmw-030
bld-centos5-32-vmw-031
bld-centos5-32-vmw-032
bld-centos5-32-vmw-033
bld-centos5-32-vmw-034
bld-centos5-32-vmw-035
bld-centos5-32-vmw-036
bld-centos5-32-vmw-037
bld-centos5-32-vmw-038
bld-centos5-32-vmw-039
bld-centos5-64-vmw-007
bld-centos5-64-vmw-008
bld-centos5-64-vmw-009
bld-centos5-64-vmw-010
bld-centos5-64-vmw-011
try-mac64-slave27
try-mac64-slave28
try-mac64-slave29
try-mac64-slave30
try-mac64-slave31
Attached patch bustage fixSplinter Review
Simplified configs with tests passing.
Attachment #637941 - Flags: review?(aki)
Attachment #637941 - Flags: review?(aki) → review+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Getting some reconfig time errors:

ImportError: cannot import name MAC_LION_MINIS

Patch incoming
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #637958 - Flags: review?(bhearsum)
Attachment #637958 - Flags: review?(bhearsum) → review+
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: