767587 - GCLI should have a type for files

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P2)

Description

[Joe Walker [:jwalker]]

Something like this:

type: 'file'

type {
  name: 'file',
  exists: ...,   // One of [yes|no|optional], default=optional
  type: ...      // One of [file|dir|any], default=any
}

Things to consider:
* This should be able to work asynchronously (get IO off main thread)
* UI should be able to offer a file selection dialog
  (check what options are available there)
* What do we do about symlinks, devices, etc
* What do we do about file permissions, readability, etc

Comment 1

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 2

[Joe Walker [:jwalker]]

Attachment: v1

There's a lot here, so you probably want this broken out: https://github.com/joewalker/gcli/pull/14

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 773955 [details] [diff] [review]
v1

Review of attachment 773955 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. The l10n comments should probably be fixed though.

::: browser/locales/en-US/chrome/browser/devtools/gcli.properties
@@ +58,5 @@
> +fileErrExists='%1$S' already exists
> +
> +# LOCALIZATION NOTE (fileErrIsNotFile): Error message given when a file
> +# argument points to a non directory, when a directory is needed (e.g. for use
> +# with 'cd') %1$S is a filename

Maybe:
Error message given when a file argument points to a non file (e.g. a directory) %1$S is a filename

@@ +63,5 @@
> +fileErrIsNotFile='%1$S' is not a file
> +
> +# LOCALIZATION NOTE (fileErrIsNotDirectory): Error message given when a file
> +# argument points to a non-file, when a directory is needed (e.g. for use with
> +# 'cd') %1$S is a filename

Maybe:
Error message given when a file argument points to a non-directory, when a directory is needed (e.g. for use with 'cd') %1$S is a directory name

Comment 4

[Joe Walker [:jwalker]]

Attachment: v2

With review comment fixes

Comment 5

[Joe Walker [:jwalker]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=93660c241ba4
Fx-Team: https://tbpl.mozilla.org/?tree=Fx-Team&rev=7c3d5bdc569c
HG Revision: https://hg.mozilla.org/integration/fx-team/rev/0ebbdfbb31eb

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/0ebbdfbb31eb