Closed Bug 767626 Opened 12 years ago Closed 12 years ago

We don't need to cache selectedText in fennec native

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

ARM
Android
defect
Not set
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

VERIFIED FIXED
Firefox 16
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This was necessary for the e10s-ness of XUL fennec, but I don't see a reason for it in fennec native, so I wrote a patch to get rid of it.

This patch also makes us more aggressive about null checks in endSelection, where I found we can run into problems if endSelection gets called after the view has been destroyed.
Attachment #635974 - Flags: review?(mbrubeck)
Attachment #635974 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/13c1c215bc5f
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/13c1c215bc5f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6
Component: General → Text Selection
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.