MediaManager must push JS context before calling callbacks.

RESOLVED INVALID

Status

()

RESOLVED INVALID
7 years ago
6 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(firefox13 unaffected, firefox14 unaffected)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 636107 [details] [diff] [review]
Use nsCxPusher before making calls to callbacks.
Attachment #636107 - Flags: review?(bugs)
(Assignee)

Comment 1

7 years ago
Guessing sg:moderate.
status-firefox-esr10: --- → unaffected
status-firefox13: --- → unaffected
status-firefox14: --- → unaffected
status-firefox15: --- → affected
status-firefox16: --- → affected
tracking-firefox15: --- → +
tracking-firefox16: --- → +
Whiteboard: [sg:moderate]
Attachment #636107 - Flags: review?(bugs) → review+
Comment on attachment 636107 [details] [diff] [review]
Use nsCxPusher before making calls to callbacks.

Actually, if these runnables are used only via event loop, 
XPConnect's push/pop should be enough. But if the runnables are used as
scriptrunners, we must have the cxpusher stuff.
(Assignee)

Comment 3

7 years ago
These runnables should run straight from the event loop, as they're posted from the a different thread to the main thread. So if we don't need them in that case, I'm fine with marking this invalid.
Keywords: sec-moderate
Whiteboard: [sg:moderate]
Keywords: regression
This bug has kind of stalled out.  Is this still valid?
Shouldn't be valid. (though, I'm not familiar with MediaManager)
Based on my understanding, XPConnect takes care of setting up the correct JS context when passing values from chrome to content. MediaManager uses standard XPConnect techniques to pass a MediaStream to the provided callback, so I think we can safely close this bug.
(In reply to Anant Narayanan [:anant] from comment #6)
> Based on my understanding, XPConnect takes care of setting up the correct JS
> context when passing values from chrome to content.
Nothing to do with this bug

> MediaManager uses
> standard XPConnect techniques to pass a MediaStream to the provided
> callback, so I think we can safely close this bug.
By default when calling a callback one should push JS context to stack, but if it is know the
callback is always async, we can rely on XPConnect to push null to the JS context stack.
Should we untrack or is there any remaining action here for FF16?
Johnny, Olli, ping on comment 8. Should we just close this out?
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → INVALID
Group: core-security
status-firefox-esr10: unaffected → ---
status-firefox15: affected → ---
status-firefox16: affected → ---
tracking-firefox15: + → ---
tracking-firefox16: + → ---
Keywords: sec-moderate
You need to log in before you can comment on or make changes to this bug.