Migrate maps on www.mozilla.org to Openstreetmap

RESOLVED WONTFIX

Status

P4
normal
RESOLVED WONTFIX
6 years ago
5 years ago

People

(Reporter: hectorz, Assigned: hectorz)

Tracking

unspecified
Future

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [u=user c=bedrock p=3])

Attachments

(2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 636136 [details] [diff] [review]
Patch

Rik suggested this map should also be updated to use Google Maps API v3[1].

This patch updates mozilla-map.js with its v3 equivalent in the PHP codebase. GBrowserCompatible/GUnload equivalent is not available in v3.

[1]: https://github.com/mozilla/bedrock/pull/160#issuecomment-6361488
Attachment #636136 - Flags: review?(anthony)

Updated

6 years ago
Attachment #636136 - Flags: review?(anthony)
So I did not push a lot to get a Gmaps3 API key. And I did not get one.

But I think that's actually a good thing. We should use OpenStreetMap. I don't know what's the best way to embed OpenStreetMap data though.

Comment 2

6 years ago
rik, I think that http://wiki.openstreetmap.org/wiki/Deploying_your_own_Slippy_Map has a few pointers for embedding OpenStreetMap.
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
So the Pull Request uses openlayers.

Can someone work with Hector to check out what we need to do in terms of licensing and if we can find a better looking provider of maps?

Comment 5

6 years ago
Malexis: One for an upcoming sprint.
Component: General → Pages & Content
Whiteboard: [u=user c=bedrock p=3]
Target Milestone: --- → Future
(Assignee)

Comment 6

6 years ago
(In reply to Anthony Ricaud (:rik) from comment #4)
> So the Pull Request uses openlayers.
> 
> Can someone work with Hector to check out what we need to do in terms of
> licensing and if we can find a better looking provider of maps?

I noticed remo is using leaflet api[1] recently, maybe @glogiotatidis/:giorgos can provide some information regarding how to get a key from CloudMade?

Also a key from CloudMade is only required if using map tiles from them. I updated the bedrock patch[2] for /firefox/geolocation to use leaflet api(which is way simpler and intuitive) and included more available tile providers for consideration.

Even more map tiles can be seen at this demo[3], but some tiles are not openstreetmap based.

Attachment 636136 [details] [diff] is for /en-US/about/contact.html which is still in PHP code, an updated patch is not attached here. With stable leaflet api v0.4.5 there are some bugs in IE, fixable by switching to non-stable master of leaflet api, but I haven't found out the real issue yet.

[1]: https://github.com/mozilla/remo/commit/58315162
[2]: https://github.com/l-hedgehog/bedrock/commit/f291f238.patch
[3]: http://seelmann.github.com/leaflet-providers/demo.html
(Assignee)

Comment 7

6 years ago
Created attachment 703681 [details] [diff] [review]
Patch, w Leaflet

(In reply to Hector Zhao [:hector_zhao] from comment #6)> 
> Attachment 636136 [details] [diff] is for /en-US/about/contact.html which is
> still in PHP code, an updated patch is not attached here. With stable
> leaflet api v0.4.5 there are some bugs in IE, fixable by switching to
> non-stable master of leaflet api, but I haven't found out the real issue yet.

leaflet api v0.5 is now released[1], updated patch attached

[1]: http://leafletjs.com/2013/01/17/leaflet-0-5-released.html
Attachment #636136 - Attachment is obsolete: true
Priority: -- → P4
(Assignee)

Comment 8

6 years ago
(In reply to Hector Zhao [:hectorz] from comment #6)
> https://github.com/l-hedgehog/bedrock/commit/f291f238.patch
Per @sgarrity's comment[1], I closed the old PR and opened a new one using leaflet api[2]

> http://seelmann.github.com/leaflet-providers/demo.html
This page has since been moved to [3]

[1]: https://github.com/mozilla/bedrock/pull/353#issuecomment-14246513
[2]: https://github.com/mozilla/bedrock/pull/661
[3]: http://leaflet-extras.github.com/leaflet-providers/demo.html
(Assignee)

Updated

6 years ago
Summary: Migrate office map to Google Maps API v3 → Migrate maps on www.mozilla.org to Openstreetmap
Hi Cmore, Rik, and Sancus -

Should we continue with this since it is on the PHP infrastructure?

Ths,
Jen
Hi Cmore, Rik, and Sancus -

Should we continue with this since it is on the PHP infrastructure?

Thx,
Jen

Comment 11

6 years ago
(In reply to jbertsch from comment #10)
> Hi Cmore, Rik, and Sancus -
> 
> Should we continue with this since it is on the PHP infrastructure?
> 
> Thx,
> Jen

Let's just make this part of the new page on Bedrock instead of updating it on the php side. Consider the php side frozen unless something is horribly broken.
(Assignee)

Comment 12

6 years ago
Comment on attachment 703681 [details] [diff] [review]
Patch, w Leaflet

(In reply to Chris More [:cmore] from comment #11)
> 
> Let's just make this part of the new page on Bedrock instead of updating it
> on the php side. Consider the php side frozen unless something is horribly
> broken.

/firefox/geolocation is already in bedrock, and a choice of tile provider is needed for pull request 661 and future work on /about/contact and other maps
Attachment #703681 - Attachment is obsolete: true

Comment 13

6 years ago
 
> /firefox/geolocation is already in bedrock, and a choice of tile provider is
> needed for pull request 661 and future work on /about/contact and other maps

Got it. Yes, let's get this resolved and find something that works for HTTPS.

PR: https://github.com/mozilla/bedrock/pull/661
I'm researching Cloudmade's SSL offering. Will reach out if I learn anything interesting.
There is code here: https://github.com/mozilla/bedrock/pull/661 by :hectorz. We are however stuck on finding a suitable tile server. I'm closing this PR for now, but we should continue to discuss here. We'll reopen the PR or file a new one when we're ready to merge this. I just wanted to make sure we documented the PR so we don't have to go searching later.

Thanks again :hectorz!
I opened a ServiceNow request to get a paid account on Cloudmade for reps.mozilla.org. I haven't heard/can't think of any reason that we can't share this account with other sites. Hope to have it soon.

The ServiceNow request (RITM0015857) is here:

https://mozilla.service-now.com/nav_to.do?uri=sc_req_item.do?sys_id=9c23f9a344f84100151826f6aa427463%26sysparm_view=ess

	

    Collapse All Comments
    Expand All Comments
    Show CC Changes
(Assignee)

Comment 17

6 years ago
(In reply to Justin Crawford [:hoosteeno] from comment #16)
> I opened a ServiceNow request to get a paid account on Cloudmade for
> reps.mozilla.org. I haven't heard/can't think of any reason that we can't
> share this account with other sites. Hope to have it soon.

That's great! Thanks!
I'm in talks with Cloudmade. They can offer us basic service, which is very economical, or a professional-grade service that includes...

* guaranteed uptime (99.9%)
* dedicated support

For our immediate needs on reps, I don't think either is essential. However, if we use Cloudmade on mozilla.org, those two might be more valuable.

:pmac, :jbertsch, :cmore (or any others): do you have strong feelings about those features? If so I will pursue the professional service.

Ping me in IRC if you want more info.
Flags: needinfo?

Comment 19

5 years ago
(In reply to Justin Crawford [:hoosteeno] from comment #18)
> I'm in talks with Cloudmade. They can offer us basic service, which is very
> economical, or a professional-grade service that includes...
> 
> * guaranteed uptime (99.9%)
> * dedicated support
> 
> For our immediate needs on reps, I don't think either is essential. However,
> if we use Cloudmade on mozilla.org, those two might be more valuable.
> 
> :pmac, :jbertsch, :cmore (or any others): do you have strong feelings about
> those features? If so I will pursue the professional service.
> 
> Ping me in IRC if you want more info.

Can you ask what their uptime has been for the past six months for their basic service? (Hopefully they won't give you a lower-than-reality uptime to sway you to the professional one)

I am find with the basic service for now. We can always upgrade later.
Flags: needinfo?
I'm fine with the basic service.
Reviews of Cloudmade are complete and we're simply waiting now for IT to purchase a credit for us. I have set up an API key for mozilla.org and will share it when we have a credit to work with. 

https://bugzilla.mozilla.org/show_bug.cgi?id=866857
I now have an API key for Cloudmade and can share it with whoever is coding this feature. Ping me on IRC to chat.

If that's you, would you please examine the docs for token-based authZ (http://developers.cloudmade.com/projects/show/auth)? I would like to use tokens if possible.
(Assignee)

Comment 23

5 years ago
(In reply to Justin Crawford [:hoosteeno] from comment #22)
> I now have an API key for Cloudmade and can share it with whoever is coding
> this feature. Ping me on IRC to chat.
> 
> If that's you, would you please examine the docs for token-based authZ
> (http://developers.cloudmade.com/projects/show/auth)? I would like to use
> tokens if possible.

Hi, Justin
I'm currently at Mobile Asia Expo, will talk to you tomorrow morning PDT, thanks!
This bug is dependent on the maps UI that will come out of bug 839563.
Depends on: 839563
Just received an email from Google Maps. The v2 API will be shut down on November 19, 2013.
(Assignee)

Comment 26

5 years ago
(In reply to Anthony Ricaud (:rik) from comment #25)
> Just received an email from Google Maps. The v2 API will be shut down on
> November 19, 2013.

Migration to v3 happened in https://bugzil.la/896147
Hey all, resolving this bug since we've moved forward with MapBox as our tile provider and I don't believe there are any other outstanding issues here. The Contact Us / Mozilla Space / Contribute redesign is targeting to go live next week. Ping me with any questions.

https://wiki.mozilla.org/Websites/Moz-Spaces-Contribute-Contactus
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
(Assignee)

Comment 28

5 years ago
(In reply to Mike Alexis [:malexis] from comment #27)
> Hey all, resolving this bug since we've moved forward with MapBox as our
> tile provider and I don't believe there are any other outstanding issues
> here. The Contact Us / Mozilla Space / Contribute redesign is targeting to
> go live next week. Ping me with any questions.
> 
> https://wiki.mozilla.org/Websites/Moz-Spaces-Contribute-Contactus

Hi Mike,

Should I open new bug for moving /firefox/geolocation/ to MapBox?

My patch based on bug-897082-contact-and-spaces branch is available at https://github.com/l-hedgehog/bedrock/commit/15b81709

Comment 29

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c8e67f1ec99bd7ca2ea988a5643ee8bdb855ee4f
Bug 767767: migrate geolocation-demo to MapBox

https://github.com/mozilla/bedrock/commit/0fe7b1278171888464224fcdbf397ea229d6daf6
Merge pull request #1452 from l-hedgehog/bug-767767-geolocation-demo-mapbox

Bug 767767: migrate geolocation-demo to MapBox
You need to log in before you can comment on or make changes to this bug.