Long tapping on disabled text inputs trigger text selection UI

REOPENED
Unassigned

Status

()

Firefox for Android
Text Selection
REOPENED
5 years ago
7 months ago

People

(Reporter: Martijn Wargers (dead), Unassigned)

Tracking

({testcase})

Trunk
ARM
Android
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
See url, steps to reproduce:
- Long tap on the plugin/plugin placeholder (depends on if you have enabled the plugin or not).

Expected result:
- No text selection handles should appear

Actual result:
- Text selection handles appear.

Two sidenotes (which are already known issue)
- The text selection handles can't be rendered over the Flash plugins
- When the plugin placeholders are shown, then going with one of the selection handles over it, causes the Flash plugin to be activated
(Reporter)

Comment 1

5 years ago
Also, text selection should probably not occur while long tapping on various form controls: http://people.mozilla.org/~mwargers/tests/forms/disabled_elements/disabledelements.html
Created attachment 677526 [details] [diff] [review]
Patch (v1)

Possible easy fix, just turn off text selection.
Attachment #677526 - Flags: review?(margaret.leibovic)
(This would mimic page behaviour as I see in my installed version of v14).

The larger question from comment #1 (and as briefly discussed on IRC) might require a separate bugzilla?

Comment 4

5 years ago
Comment on attachment 677526 [details] [diff] [review]
Patch (v1)

I'm confused by why you're changing aboutAddons.css. This bug is about what happens with you long tap on a "Tap to play" plugin placeholder, like in the URL Martijn linked to. To fix this issue, we probably want to check the type of element in startSelection and bail if it's a plugin object. To address comment 1, we could also bail for other kinds of elements, like buttons.
Attachment #677526 - Flags: review?(margaret.leibovic) → review-
Ah drats ... confused plugins with addons page
Component: General → Text Selection
Pruning some old bugs obviated by new Core/Layout AccessibleCaret implementation, or being no longer observable.

(Please re-open if appropriate.)
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

2 years ago
It still happens for disabled text input elements.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Long tapping on plugins/plugin placeholders trigger text selection UI → Long tapping on disabled text inputs trigger text selection UI
(Reporter)

Updated

7 months ago
Status: REOPENED → RESOLVED
Last Resolved: 2 years ago7 months ago
Resolution: --- → WORKSFORME
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
You need to log in before you can comment on or make changes to this bug.