Closed Bug 767806 Opened 10 years ago Closed 10 years ago

Don't create a useless string every time we check for input's validity

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file)

Patch
973 bytes, patch
justin.lebar+bug
: review+
mounir
: checkin+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review 
nsHTMLInputElement::HasPatternMismatch is creating a string for @pattern every time, even if @pattern isn't set. It seems that we can save a few cycles by not doing so.
Attachment #636166 - Flags: review?(justin.lebar+bug)
I should add that the validity of an input element is checked everytime the value is changed (more or less).
Comment on attachment 636166 [details] [diff] [review]
Patch

Woo, first official DOM peer review!
Attachment #636166 - Flags: review?(justin.lebar+bug) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla16
Attachment #636166 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/c995cbc6f7fc
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.