Don't create a useless string every time we check for input's validity
RESOLVED
FIXED
in mozilla16
Status
()
People
(Reporter: mounir, Assigned: mounir)
Tracking
Bug Flags:
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
973 bytes,
patch
|
justin.lebar+bug
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
Created attachment 636166 [details] [diff] [review] Patch nsHTMLInputElement::HasPatternMismatch is creating a string for @pattern every time, even if @pattern isn't set. It seems that we can save a few cycles by not doing so.
Attachment #636166 -
Flags: review?(justin.lebar+bug)
|
(Assignee) | |
Comment 1•7 years ago
|
||
I should add that the validity of an input element is checked everytime the value is changed (more or less).
|
||
Comment 2•7 years ago
|
||
Comment on attachment 636166 [details] [diff] [review] Patch Woo, first official DOM peer review!
Attachment #636166 -
Flags: review?(justin.lebar+bug) → review+
|
|
(Assignee) | |
Updated•7 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → mozilla16
|
|
(Assignee) | |
Updated•7 years ago
|
||
Attachment #636166 -
Flags: checkin+
|
||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c995cbc6f7fc
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•