767852 - reader settings popup menu should be cancelable by pressing Back

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cameron McCormack (:heycam)]

You should be able to dismiss the menu that comes up when you press the "Aa" button in a Reader mode page by pressing the Back button.  At least, I pressed back expecting it to do this, and instead it navigated the page back.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Dismiss any open dropdowns on Android back button

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 637533 [details] [diff] [review]
Dismiss any open dropdowns on Android back button

>diff --git a/mobile/android/chrome/content/aboutReader.js b/mobile/android/chrome/content/aboutReader.js


>+      case "popstate":
>+        if (!aEvent.state) {
>+          this._closeAllDropdowns();
>+        }

{} not needed

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 637533 [details] [diff] [review]
> Dismiss any open dropdowns on Android back button
> 
> >diff --git a/mobile/android/chrome/content/aboutReader.js b/mobile/android/chrome/content/aboutReader.js
> 
> 
> >+      case "popstate":
> >+        if (!aEvent.state) {
> >+          this._closeAllDropdowns();
> >+        }
> 
> {} not needed

Fixed.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/6f41a0fde6d2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f41a0fde6d2