Closed Bug 767916 Opened 8 years ago Closed 8 years ago

Decode percent encoding on non-ASCII filename when saving a video snapshot.

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.13

People

(Reporter: philip.chee, Assigned: ananuti)

Details

(Whiteboard: [good first bug][mentor=IanN][lang=js][level=oneliner])

Attachments

(1 file)

patch
1.29 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review 
From Firefox Bug 734027 (Non-ASCII filename is shown as escaped unicode when saving a snapshot from video):

> Steps to reproduce:
> 1. Give video file Non-ASCII filename, for example: Basilique du Sacré-Cœur de 
> Montmartre.ogg
> 2. Play this file in Firefox
> 3. Right click on the video and select "Save Snapshot as..."
> 
> Actual result:
> Snapshot file shows escaped unicode instead of non ASCII characters
> 
> Expected result:
> Snapshot file name should contain the correct non-ascii characters.

Simple one line fix. See Firefox attachment 604004 [details] [diff] [review]:
> -        name = url.fileBaseName + ".jpg";
> +        name = decodeURI(url.fileBaseName) + ".jpg";

MXR shows the location of the equivalent SeaMonkey code:
<http://mxr.mozilla.org/comm-central/search?string=fileBaseName+%2B+".jpg"&find=%2Fsuite%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central>
Attached patch patch — — Splinter Review
Attachment #637371 - Flags: review?(iann_bugzilla)
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Comment on attachment 637371 [details] [diff] [review]
patch

r=me, thanks for the patch
Attachment #637371 - Flags: review?(iann_bugzilla) → review+
Hi Ekanan Ketunuti! Do you have checkin access to comm-central or do you need assistance checking this patch in?
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/4c32741c3951
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.13
You need to log in before you can comment on or make changes to this bug.