767916 - Decode percent encoding on non-ASCII filename when saving a video snapshot.

Status: RESOLVED FIXED

(SeaMonkey :: Download & File Handling, defect)

Description

[Philip Chee]

From Firefox Bug 734027 (Non-ASCII filename is shown as escaped unicode when saving a snapshot from video):

> Steps to reproduce:
> 1. Give video file Non-ASCII filename, for example: Basilique du Sacré-Cœur de 
> Montmartre.ogg
> 2. Play this file in Firefox
> 3. Right click on the video and select "Save Snapshot as..."
> 
> Actual result:
> Snapshot file shows escaped unicode instead of non ASCII characters
> 
> Expected result:
> Snapshot file name should contain the correct non-ascii characters.

Simple one line fix. See Firefox attachment 604004 [details] [diff] [review]:
> -        name = url.fileBaseName + ".jpg";
> +        name = decodeURI(url.fileBaseName) + ".jpg";

MXR shows the location of the equivalent SeaMonkey code:
<http://mxr.mozilla.org/comm-central/search?string=fileBaseName+%2B+".jpg"&find=%2Fsuite%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central>

Comment 1

[Ekanan Ketunuti]

Attachment: patch

Comment 2

[Ian Neal]

Comment on attachment 637371 [details] [diff] [review]
patch

r=me, thanks for the patch

Comment 3

[Philip Chee]

Hi Ekanan Ketunuti! Do you have checkin access to comm-central or do you need assistance checking this patch in?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/4c32741c3951