Closed Bug 768019 Opened 11 years ago Closed 11 years ago

Cached CSS warnings are displayed as JavaScript warnings on Web Console open

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 16

People

(Reporter: paul, Assigned: msucan)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 files)

test
243 bytes, text/html
Details
screenshot
17.63 KB, image/png
Details
[in-fx-team] proposed patch
2.21 KB, patch
paul
: review+
Details | Diff | Splinter Review
Attached file test — 
      No description provided.
Attached image screenshot — 

    
    

    
  
How do you reproduce the bug?

I tried this and I only see one CSS warning in the Web Console and in the Error Console.

    
    

    
  
STR:
- open test.html in a new tab
- switch to the tab
- wait until the page is loaded
- open the web console

Actual Result:
- JS warning "unknown property"

    
    

    
  
Ah, so I have to open the Web Console after the error happens.

Thanks for the STR. I was able to reproduce now. I have a hunch what's causing this. Will look into fixing it ASAP.

    
  
Summary: CSS warnings are displayed as JavaScript warnings → Cached CSS warnings are displayed as JavaScript warnings on Web Console open

    
    

    
  


  
This fixes the problem for me. It is an embarrassingly simple fix: I passed the wrong argument to the function that determines the cached message category.

Thanks for your report!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED

        Attachment #636374 -
        Flags: review?(paul)

    
  

        Attachment #636374 -
        Flags: review?(paul) → review+

    
    

    
  
Thanks for the r+!
Whiteboard: [land-in-fx-team]

    
    

    
  
Comment on attachment 636374 [details] [diff] [review]
[in-fx-team] proposed patch

https://hg.mozilla.org/integration/fx-team/rev/e42cc35e45cc

        Attachment #636374 -
        Attachment description: proposed patch → [in-fx-team] proposed patch

    
  
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e42cc35e45cc
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.