Closed Bug 768106 Opened 10 years ago Closed 10 years ago

TouchPal Keyboard deletes entered text when trying to autocomplete first word

Categories

(Firefox for Android Graveyard :: Keyboards and IME, defect, P2)

16 Branch
ARM
Android
defect

Tracking

(firefox14 unaffected, firefox15+ unaffected, firefox16+ verified, firefox17 verified)

VERIFIED FIXED
Firefox 17
Tracking Status
firefox14 --- unaffected
firefox15 + unaffected
firefox16 + verified
firefox17 --- verified

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

After you have entered the first word (and a space), autocompleting subsequent words works correctly.

My example assumes your form autocomplete history includes an entry for the word "cat".

STR:
1. Load any page with a text input form. I like using the Firefox Mobile Support page.
2. Type "c"
3. See "c|"
4. Select autocomplete entry "cat"

AR: See "|"
ER: See "cat|"
We are tracking bug 764193 for Fennec 15. If we want to re-enable the form autocomplete popup for Fennec 15, we should also track this TouchPal autocomplete bug.
Status: NEW → ASSIGNED
Priority: -- → P2
Ignore empty composing events when we have no composition string to replace.

If the VKB sends us a replacement composition string that is empty and we have no active composition string to replace, then just ignore the empty string. Some VKBs, such as TouchPal Keyboard, send us empty strings at inopportune times, deleting committed text.

This bug is one of the few remaining blockers preventing us from re-enabling form autocomplete (bug 764193).
Attachment #642735 - Flags: review?(blassey.bugs)
Attachment #642735 - Flags: review?(blassey.bugs) → review+
Target Milestone: --- → Firefox 17
If we fix bug 764193 (re-enable form autocomplete) in Firefox 16, we should uplift this patch, too.
https://hg.mozilla.org/mozilla-central/rev/c033e6c7c407
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Aurora/Beta nom?
Comment on attachment 642735 [details] [diff] [review]
ignore-empty-composing-events.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Form autocomplete has just be re-enabled on Aurora 16, so it will break badly for TouchPal VKB users if we don't have this fix.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk because the code change is just ignoring some empty strings sent from the TouchPal VKB.
String or UUID changes made by this patch: None
Attachment #642735 - Flags: approval-mozilla-aurora?
Comment on attachment 642735 [details] [diff] [review]
ignore-empty-composing-events.patch

Low risk, and we'll need this for re-enabled form autocomplete. Approving.
Attachment #642735 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Firefox 14 and Beta 15 are unaffected because form autocomplete is disabled on those channels.
^^^ Please ignore comment 11. That link points to the wrong changeset and the wrong branch.

This is the correct changeset for Aurora 16:
https://hg.mozilla.org/releases/mozilla-aurora/rev/51701d1f4bcc
Blocks: 781020
Verified fix on: Firefox Mobile 16 beta 2, Nightly 18.0a1 2012-09-04 and Aurora 17.0a2 2012-09-04 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.