768106 - TouchPal Keyboard deletes entered text when trying to autocomplete first word

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect, P2)

Description

[Chris Peterson [:cpeterson]]

After you have entered the first word (and a space), autocompleting subsequent words works correctly.

My example assumes your form autocomplete history includes an entry for the word "cat".

STR:
1. Load any page with a text input form. I like using the Firefox Mobile Support page.
2. Type "c"
3. See "c|"
4. Select autocomplete entry "cat"

AR: See "|"
ER: See "cat|"

Comment 1

[Chris Peterson [:cpeterson]]

We are tracking bug 764193 for Fennec 15. If we want to re-enable the form autocomplete popup for Fennec 15, we should also track this TouchPal autocomplete bug.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking as per comment 1

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: ignore-empty-composing-events.patch

Ignore empty composing events when we have no composition string to replace.

If the VKB sends us a replacement composition string that is empty and we have no active composition string to replace, then just ignore the empty string. Some VKBs, such as TouchPal Keyboard, send us empty strings at inopportune times, deleting committed text.

This bug is one of the few remaining blockers preventing us from re-enabling form autocomplete (bug 764193).

Comment 4

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c033e6c7c407

Comment 5

[Chris Peterson [:cpeterson]]

If we fix bug 764193 (re-enable form autocomplete) in Firefox 16, we should uplift this patch, too.

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c033e6c7c407

Comment 7

[Aaron Train [:aaronmt]]

Aurora/Beta nom?

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 642735 [details] [diff] [review]
ignore-empty-composing-events.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Form autocomplete has just be re-enabled on Aurora 16, so it will break badly for TouchPal VKB users if we don't have this fix.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low risk because the code change is just ignoring some empty strings sent from the TouchPal VKB.
String or UUID changes made by this patch: None

Comment 9

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 642735 [details] [diff] [review]
ignore-empty-composing-events.patch

Low risk, and we'll need this for re-enabled form autocomplete. Approving.

Comment 10

[Chris Peterson [:cpeterson]]

Firefox 14 and Beta 15 are unaffected because form autocomplete is disabled on those channels.

Comment 11

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6994473b0b4

Comment 12

[Chris Peterson [:cpeterson]]

^^^ Please ignore comment 11. That link points to the wrong changeset and the wrong branch.

This is the correct changeset for Aurora 16:
https://hg.mozilla.org/releases/mozilla-aurora/rev/51701d1f4bcc

Comment 13

[Adrian Tamas (:AdrianT)]

Verified fix on: Firefox Mobile 16 beta 2, Nightly 18.0a1 2012-09-04 and Aurora 17.0a2 2012-09-04 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4)