768232 - [ia] Add product field to wiki documents mapping (search index)

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

We need to be able to filter/query/facet documents by product. Once the database pieces are in place, we need to put this into the ES index.

This means at least updating the `get_mapping() and `extract_document`.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Before doing this, we need to make sure we can facet on a list of strings (how we currently index tags, for example). Assuming we can, making this a 1pt. If there are limitations on faceting a list of strings, the pts will need to be adjusted accordingly.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Faceting on lists of strings won't be a problem.

For example:

    doc1 = tags ['a', 'b', 'c']
    doc2 = tags ['a']

Faceting on the 'tags' field yields these counts:

    a - 2
    b - 1
    c - 1

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Adding [ia] to title.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this one.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is more involved.

1. add the field to the mapping
2. add the extraction code which pulls from products and adds to the mapping

However, by the time we're working on this bug, the code it relies on is using the new product system.

Thus, we need to finish it off:

3. update the search views to use the product field rather than the tags field for wiki documents

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

willkg, can I grab this to do it together with the mapping changes for topic? It would be one less mapping change and reindex dance.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

You're right, but this depends on the product stuff, not the topic stuff. So if you do it, you still have to land this with the migration product changes.

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Grabbing to do it with topics and I have the itch. It will need to wait until the blockers land before landing though but I will have the commit ready.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

This is in a pull request that needs a little more work:
https://github.com/mozilla/kitsune/pull/741

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

This landed on master:

Part 1:
https://github.com/mozilla/kitsune/commit/599551e13092de60a5755e4383376bab048edaff

Part 2:
https://github.com/mozilla/kitsune/commit/ee2f2f21fbb4f46f982b51aba768d399c3d09d04

Now I am doing the 2 step deploy to stage. If that works, it goes to prod after.

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

Landed my first index mapping change on prod \o/