Closed Bug 768278 Opened 8 years ago Closed 3 years ago

"Update could not be installed. Please make sure there are no other copies of Firefox running on your computer." with UAC off

Categories

(Toolkit :: Application Update, defect)

17 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: borlosky, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120624030537

Steps to reproduce:

Opened Nightly


Actual results:

update could not be installed Please make sure there are no other copies of Firefox running on your computer


Expected results:

should have updated normally
Component: Untriaged → Installer
Hardware: x86 → x86_64
Component: Installer → Application Update
Product: Firefox → Toolkit
QA Contact: untriaged → application.update
problem is back again today, after restarting firefox 20+ times, update still fails to apply, i've set nightly to run as admin, deleted update files in (C:\Users\<name>\AppData\Local\Mozilla\Firefox\Nightly), and still fails to update accordingly. nightly states i'm running build from 6/25..it's now 6/27, just will NOT update for anything.
Please provide the steps used to run as admin. Thanks
i've tried right-clicking shortcut and click "run as admin", also, have gone to actual exe, right clicked and checked "run as administrator" on compatibility tab.(which coincidentally seems to keep UNCHECKING it self some time later on it's own)
Do you have UAC turned on? Do you have to enter a username and / or password when you select run as admin?
UAC is completely turned off (Never Notify)
and problem back again tonight, firefox.exe has mysteriously unclicked itself from "run as admin" once more. but even after setting to run as admin, once again, update still fails to apply. deleted content in updates folder AGAIN, ran as admin, update still not applied. this issue is extremely irritating since this happens at LEAST once a day, i really don't wanna have to spend 20 minutes every time I open Nightly,only to restart it 30 times to ATTEMPT to get it to update.
and back again today....all info exactly the same....admin is no longer checked mysteriously, restarted numerous times/deleted updates folder, still won't update....
a little more info, when i go to help> about nightly, it states it's downloading update, but seems to stop at applying update (nightly still running in admin mode), keep in mind i've left it at this stage for many hours with no success. anyway, i close nightly since it won't get past this stage, then restart once again (back into admin mode of course) it will FINALLY update to current version, but keep in mind, i have to do this for EVERY update....

step 1, re-check run as admin in exe properties as it mysteriously un-checks itself at random times (even if pc has not been restarted/shut down in many days)
step 2, delete all update folder contents in C:\Users\<user>\AppData\Local\Mozilla\Firefox\Nightly
step 3, restart nightly (right click-run as admin even though it's already set as admin in properties)
step 4, get error could not install update
step 5, close nightly
step 6, restart nightly (right click on .exe, "run as admin")
step 7, get error that nightly cannot install update, again
step 8, close said error
step 9, click help>about nightly
step 10, let nightly download update
step 11, wait for nightly to get stuck on applying update
step 12, close nightly
step 13, open nightly in admin mode, again
step 14, nightly updates to current version, finally

may just be my opinion here, but going through this EVERY SINGLE time nightly is updated is a tad excessive (to put it mildly), any help would be appreciated, or i'll sadly be forced to uninstall mozilla for good...i can't spend 10-15 mins every time there's an update to deal with this.
I haven't had time to get into the details for this bug but it does have to do with running as admin not being supported in part due to iirc the permissions being set on the files when running as admin.
and problem back again today.....everything same as before
is there any other information I could post to assist in this??
and same issue again today
is there anyway i can just turn off updates all together?? if i can't fix this issue, i'd just prefer to leave updates off.
and back again, today....no different from before
I give up, this is too frustrating and too much of a loss to my productivity to keep going thru this EVERY SINGLE day. Since no one seems to know how to fix.... Only left with the option of uninstalling Nightly and changing to Chrome, was a good run while it lasted...
a quick update, tried to re-install nightly after a couple weeks of not having it anymore, and after first day, SAME identical problem is back....
...only now it seems no matter what i do, nightly will not update, tried following steps that worked before, and nothing now, ANY help at this point would be appreciated
I suggest finding out what is in update.log. In my case, WinXP, the following files are often locked, causing the infinite loop of update failures:

firefox.exe
plugin-container.exe

Since I use Aurora in WinXP, my update logs are in
"c:\documents and settings\{user name}\Local Settings\Application Data\Mozilla Firefox\Aurora\updates"
and in the subdirectory "0"

I am still investigating why the file is locked, but the name of the locking process is "System". I use MS Security Essentials, so am also tracking Bug 775458.

Downloading the full installer is the workaround. I have seen the same bug in Thunderbird release.
Another workaround is a full reboot.
See also: Bug 776210
in the meantime, i've set nightly to never check for updates, so I don't get this every single day...
This bug is for "16 branch", which covers where I've seen it: Thunderbird 14, Aurora 15, Aurora 16. Nightly 17 has a different updater, the "background" updater. Nightly 16 also had the background updater. Maybe I'm on the wrong bug.

What is in your update log? Nirsoft utilities can tell you if a file is locked.
Performing a replace request
SOURCE DIRECTORY C:\Users\Brandon\AppData\Local\Mozilla\Firefox\Nightly\updates\0
DESTINATION DIRECTORY C:\Program Files\Nightly\updated
Begin moving sourceDir (C:\Program Files\Nightly) to tmpDir (C:\Program Files\Nightly.bak)
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 1 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 2 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 3 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 4 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 5 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 6 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 7 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 8 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 9 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
PerformReplaceRequest: sourceDir rename attempt 10 failed. File: C:\Program Files\Nightly. Last error: 5, err: 7
rename_file: proceeding to rename the directory
rename_file: failed to rename file - src: C:\Program Files\Nightly, dst:C:\Program Files\Nightly.bak, err: 13
Moving sourceDir to tmpDir failed, err: 7
calling QuitProgressUI
as of now i'm now running 17 branch, and issue still here, now stuck on update from 7/20

(In reply to kitchin from comment #22)
> This bug is for "16 branch", which covers where I've seen it: Thunderbird
> 14, Aurora 15, Aurora 16. Nightly 17 has a different updater, the
> "background" updater. Nightly 16 also had the background updater. Maybe I'm
> on the wrong bug.
> 
> What is in your update log? Nirsoft utilities can tell you if a file is
> locked.
Version: 16 Branch → 17 Branch
Yep, I just had it happen in Nightly 17. This time "firefox.exe" was locked. Other times it has been "plugin-container.exe". I am using WinXP, which tends to leaves locks on files. Your problem looks different, since it involves the backup files. Have you restarted the computer since July 20?

DEVELOPERS: this can be fixed. I use a utility called Unlocker to unlock the file and that fixes it. So the Mozilla code can do the same thing. Otherwise users are left on old versions.
I suspect the updater is contending with MS Security Essentials. The lock on the file is by System. Just had it happen with Seamonkey Beta 2.13b4 (equivalent to FF 16b4).
10-30-12:  Seen for months with Updates.  Solution then was to turn of Firefox via Task Manager then execute downloaded update.  Then no problem till next Mozilla Firefox Update.  Lately (around a month) getting message each time Firefox starts, I click "OK" and Firefox starts.  The Version is the current one.  Win-7 64-bit, i7, 6-gig RAM, 1-terabyte HD.
On a whim, I decided I'd try to allow Nightly to try and update (was still stuck on update from 7/20) and same issue still. So I manually installed nightly again from the website, update went through fine that way, just did not go through with auto-update, or force-checking updates from about page... We'll see what happens again on next update though...
Duplicate of this bug: 776210
Summary: update could not be installed Please make sure there are no other copies of Firefox running on your computer → "Update could not be installed. Please make sure there are no other copies of Firefox running on your computer."
So, [i](using Nightly 48.0a1 x64 in win10 x64, with e10s enabled)[/i]
yesterday (2016-04-09) and today (2016-04-10), 
after I pressed Help|About Nightly, and the daily update was downloaded and I got the prompt to click the button to "restart Nightly to update",
I got the message that "The update could not be installed. Please make sure there are no other copies of Firefox running on your computer, and then restart Firefox to try again.".

But there were no extra instances of firefox.exe running (I hadn't started Nightly using the -no-remote command line option)
nor were any any extra windows (normal or private) open at that time.

So, I pressed ok to launch Firefox and then I closed+restarted Firefox, 
and then I opened Help|About Nightly and pressed the button once more: now the update was applied ok.

Note: I tried it also in a virtual machine (vmware workstation) of win10x64, in a clean profile
(i.e. saved a virtual machine snapshot at the point where I got the prompt to "restart Nightly to update")
and it was recreated every time I restored the snapshot
(i.e. the first time I pressed the button I would get the error about other copies of FF running, but the second time the update was applied ok).



PS. It's been a while since I tried again my Nightly installation. (so I can't tell whether it occurs on previous builds ).
>> (i.e. the first time I pressed the button I would get the error about other copies of FF running, 
>> but the second time the update was applied ok).
In other words, the first time I pressed the button I would get the error,
but, the second time, I would get the UAC prompt "Do you want to allow this app to make changes to your PC?" and pressing Yes would apply the update.
(In reply to Kostas from comment #30)
The recent landing of a patch caused what you experienced on nightly, the patch was backed out, and what you experienced should be fixed in a couple of days on nightly.
Summary: "Update could not be installed. Please make sure there are no other copies of Firefox running on your computer." → "Update could not be installed. Please make sure there are no other copies of Firefox running on your computer." with UAC off
Summary: "Update could not be installed. Please make sure there are no other copies of Thunderbird running on your computer."

I have little of this wort of trouble on FireFox of late. But Thunderbird updates always seem to fail with this error.

I took a look at the update logs and noted the path notation error "\Mozilla Thunderbird/thunderbird.exe". Could this be relevant? See excerpts below.

C:\Users\<user>\AppData\Local\Thunderbird\updates\8216C80C92C4E828\updates\backup-update.log:

EXECUTE PATCH thunderbird.exe
rename_file: failed to rename file - src: C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe, dst:C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe.moz-backup, err: 13
### execution failed

C:\Users\<user>\AppData\Local\Thunderbird\updates\8216C80C92C4E828\updates\last-update.log:

EXECUTE PATCH thunderbird.exe
rename_file: failed to rename file - src: C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe, dst:C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe.moz-backup, err: 13
### execution failed
PS, the Thunderbird update version is 45.5.1. The buildID is "20161130024037".
Sorry to keep dribbling information. But I'm trying to be complete while searching other sites as well.  

Thunderbird launches with Admin privileges on my system.

So, to me, it looks like the installer cannot find the path, due to the above mentioned notation error in the installer (assuming that it is not just an error in the logging). Results from Windows dir:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:>dir C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe
Parameter format not correct - "hunderbird.exe".

C:>dir "C:\Program Files (x86)\Mozilla Thunderbird/thunderbird.exe"
 Volume in drive C is System
 Volume Serial Number is <sernum>

 Directory of C:\Program Files (x86)\Mozilla Thunderbird

File Not Found
Closing old bugs as incomplete. If this is still an issue please file a new bug.
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.