76828 - Arrows not disappearing when reaching the top or bottom of a scrollable menu (eg bookmarks)

Status: NEW

(Core :: XUL, defect)

Description

[doctor__j]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.8.1+) Gecko/20010419
BuildID:    2001041904

Reproducible: Always

Steps to Reproduce:
1. Use "Bookmarks -> Manage Bookmarks..." to import the attached bookmark.
2. In browser, choose "Bookmarks".  Then move mouse to the big bookmark folder.
3. See the Up and Down triangle to appear in the Bookmark menu.
4. Up or Down triangle also appears unnecessarily when scrolling to the top and
bottom of the bookmark list.

Expected Results:
1. Up and Down triangle should not appear in the Bookmark pulldown menu.
2. Up triangle should appear only when the scrolling list is already at the top.
3. Down triangle should appear only when the scrolling list is already at the
bottom.

Comment 1

[doctor__j]

Attachment: Import this long bookmark to test the bug.

Comment 2

[:deanis74]

Are you sure these are the results that you expect?  I would think that you
would want is:

1. When the top of a scrollable menu is visible, the up arrow should not appear
or should at least be disabled, because it is not possible to move up any further.
2. When the bottom of a scrollable menu is visible, the down arrow should not
appear ...

I seem to remember see this in a bug before, but can't find it.

Comment 3

[doctor__j]

Oh..  Sorry.  My mind just got whacked up...

Comment 4

[sairuh (rarely reading bugmail)]

->bookmarks.

Comment 5

[Claudius Gayle]

yeah I just noticed this myself. You don't need anything fancy to repro this.
Just take your window and move it close enough to the bottom of your screen so that your
bookmarks menu would have to scroll to show the whole thing. Click on the toplevel
'Bookmarks' menu and you'll see that the 'up' scroll arrow appears needlessly.

I've seen this behavior on Win98 and Linux with the 2001041908 builds. Mac builds behave
correctly in this case.

Comment 6

[:deanis74]

*** Bug 77482 has been marked as a duplicate of this bug. ***

Comment 7

[Kelly Price]

Bug still exists on Linux build 2001052808

Comment 8

[Chris Hiner]

Dup of bug 75142?  It's got a workaround patch on it.

Comment 9

[Claudius Gayle]

john, i did a little search and didn't find a smoking gun - but this and bug 75142 basically
sound like toolkit bugs that I would imagine pink or someone already has. Is there somebug
I can lump these into?

Comment 10

[John Morrison]

bug 82936 refers specifically to collapsing the down arrow when you reach the
end of the scrollable contents. The notion of collapsing the up arrow in a 
similar fashion has been mentioned, but I can't find a specific bug report 
stating that (not that it isn't there, somewhere...). [If someone can find
another earlier RFE like this one, then please dup this].

This would need some toolkit support, although much would be in XBL I think
(at least on linux/w32). But, that would be feature work, and this would have
to queue up for post 0.9.2. (Can someone rework the Summary; it's a bit vague
about what "unnecessary" means).

Comment 11

[John Morrison]

*** Bug 82936 has been marked as a duplicate of this bug. ***

Comment 12

[Claudius Gayle]

I like the summary of the dupe.
If you click on the bookmarks menubutton and you see unecessary scroll arrows - that's
probably bug 75142.

If you actually need scroll arrows and then when you scroll to the top/bottom the arrows are
still there that's this bug. reassigning.

Comment 13

[Mike Pinkerton (not reading bugmail)]

i swear i already have this bug, but...

Comment 14

[doctor__j]

Updating summary for better wording.

This bug addresses the *greying out* of arrows at both ends of a scrollable menu
while bug 75142 is dealing with *where* the arrow is needed.

Comment 15

[doctor__j]

Hmmm...

When I said "greying out", that's just a suggestion, which I think (after a few
minutes) is really not a good way of handling the arrow.  The arrow should be
gone at all rather than staying there and appearing greyed out.  [Must...
find... coffee...  Must... find... coffee... Zzzzz]

Comment 16

[Deven Corzine]

The scrolling arrows should definitely disappear when at either end.  I keep
trying to add a bookmark and keep having to correct myself to click on the right
menu item after the up arrow pushes it down.  If the arrows didn't appear when
not needed, this wouldn't happen.  (Besides, isn't this how Windows does it?)

Comment 17

[John Morrison]

*** Bug 92024 has been marked as a duplicate of this bug. ***

Comment 18

[Ashley Bischoff (blog at handcoding.com)]

*** Bug 97794 has been marked as a duplicate of this bug. ***

Comment 19

[:deanis74]

*** Bug 99908 has been marked as a duplicate of this bug. ***

Comment 20

[:deanis74]

mpt's comments from 99908:

Appropriate behavior is as follows:
*   When the first item in the menu is visible, the upward auto-scroll arrow
    should not be present.
*   When the last item in the menu is visible, the downward auto-scroll arrow
    should not be present.
*   As the menu auto-scrolls to make the first/last item visible, that item
    should replace the upward/downward auto-scroll arrow in the menu. (That's 
    why the auto-scroll area needs to be exactly the same height as a menu
    item.)

Comment 21

[Damian Yerrick]

Additionally:
*   The height of a menu should always be a multiple of the height of an
    item to avoid displaying partial items.

Comment 22

[Jesse Ruderman]

*** Bug 152027 has been marked as a duplicate of this bug. ***

Comment 23

[John Levon]

*** Bug 146816 has been marked as a duplicate of this bug. ***

Comment 24

[John Levon]

re-summarise to mention most obvious example

Comment 25

[Brian Carpenter [:geeknik]]

just wanted to add that this is present in Phoenix 0.5.  can't remember if it
was in 0.4 and I don't feel like reinstall 0.4 to find out. :)

Comment 26

[Stephan Hohe]

This bug still exists in 1.8a

Comment 27

[C. Fox]

There's so many dups/similar bugs of this I'm not sure which is the one I want
to watch anymore.

Comment 28

[Håkan Waara]

Almost finished with a patch for this and bug 222274 (firefox).

Comment 29

[Håkan Waara]

See bug 222274 for patches

Comment 31

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 8 duplicates.
:enndeakin, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 32

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.