768392 - GCLI command to refresh the Tilt visualization mesh

Status: RESOLVED WONTFIX

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Joe Walker [:jwalker]]

Comment on attachment 636659 [details] [diff] [review]
v1

Review of attachment 636659 [details] [diff] [review]:
-----------------------------------------------------------------

(Cut and paste alert!)

I do think we need to add some tests for these commands. We've skipped it in the past and got bitten.
It's not hard, because there is a framework to help.

Examples:
- browser/devtools/commandline/test/browser_gcli_commands.js
- browser/devtools/commandline/test/browser_gcli_edit.js

There is even documentation (which I should perhaps move to MDN):
- browser/devtools/commandline/test/head.js
  See the doc comments for DeveloperToolbarTest.checkInputStatus()
  and DeveloperToolbarTest.exec()

Thanks,

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Filter on teabags

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I will create tests for this

Comment 5

[Victor Porof [:vporof][:vp]]

Thanks Mike, but the reasons I'm delaying this a bit is that the commad relies on a pretty uncomfortable hack, which exposes some private APIs in Tilt. There are a few bugs on file that plan to fix this, all of them already have patches, so it's likely that I'll change this in the almost-near future.

Theoretically this works ok as it is, but I'm not feeling quite positive about it. Let's postpone this for a short while, until Tilt settles.

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Okay, my apologies. I will update the spreadsheet.

Comment 7

[Joe Walker [:jwalker]]

New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"

Comment 8

[Victor Porof [:vporof][:vp]]

Filter on TILT QUODLIBET.

Comment 9

[Joe Walker [:jwalker]]

Resetting priorities because these P* levels are very out of date.
Sorry for the bug spam. Filter on Lobster Thermidor

Comment 10

[Joe Walker [:jwalker]]

Triage. Filter on Lobster Thermidor.
Tilt being killed by e10s.