768500 - The role="menubar/menu/menuitem" in the navigation should be removed

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[Isac Lagerblad (:icaaq)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120625030537

Steps to reproduce:

1. Press Cmd+N to open a new browser window, then type https://www.mozilla.org/en-US/ in the address bar and press Enter
2. Inspect the element #nav-main


Actual results:

The element has a role="menubar" and child-elements of the element has a variety of role="menu/menuitem" attached to themselves.


Expected results:

The element should have the attribute role="navigation" and all of it's child-elements should remove the attributes role="menu/menuitem".

To clarify the use role="navigation", As the WAI-ARIA spec [1] says: "A collection of navigational elements (usually links) for navigating the document or related documents." 

The role="menubar/menu" is more suitable for application-like menus such as the demo here [2] or google docs like applications. 

[1]http://www.w3.org/TR/wai-aria/roles#navigation
[2]http://test.cita.illinois.edu/aria/menubar/menubar1.php

Comment 1

[Kohei Yoshino [:kohei]]

My original implementation is here: http://mozilla.jp/

http://www.mozilla.org/en-US/ doesn't have dropdown menus but
http://www.mozilla.org/en-US/firefox/fx/ has.

As far as I've tested with NVDA, role="menu/menuitem" works well (in the latter case).

Comment 2

[Marco Zehe (:MarcoZ)]

Yes, they may work, but they're not appropriate here. menu/menuitem is used in contexts where a web app simulates a true desktop application. A role of menubar, for example, suggests to the blind user that they can focus this and move through the items via the left and right arrow keys, and drop a menu down with the down arrow key, etc.

For a simple navigation which we have here, where one can expand and collapse items, a simple aria-expanded="true" for when a link expands other links, and aria-expanded="false" when the stuff expanded by this link is currently not visible, suffices totally here.

Comment 3

[Kohei Yoshino [:kohei]]

Understood. Thanks for letting me know, I'll fix up my implementation at mozilla.jp. Someone at MoCo may work on the forked mozilla.org code.

Comment 4

[Kohei Yoshino [:kohei]]

Fixed on our side: http://mozilla.jp/
Somehow the keyboard shortcut with right/left keys no longer works when NVDA is running, though.

Comment 5

[Isac Lagerblad (:icaaq)]

I just tried http://www.mozilla.org with Firefox nightly, chrome and safari using VoiceOver the links in the navigation is unclickable.

I've made a pullrequest where all the role="menubar/menu/menuitem" has been removed.

Comment 6

[Isac Lagerblad (:icaaq)]

I just tried http://www.mozilla.org with Firefox nightly, chrome and safari using VoiceOver the links in the navigation is unclickable.

I've made a pullrequest where all the role="menubar/menu/menuitem" has been removed.

https://github.com/mozilla/bedrock/pull/381

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a81d82c1153c8482e39a0256aeb8f1be6953827a
Merge pull request #381 from icaaq/bug-768500-remove-menu-roles

Bug 768500 remove menu/menubar/menuitem roles

Comment 8

[Anthony Ricaud (:rik)]

This has been pushed to production.