Closed Bug 768584 Opened 12 years ago Closed 12 years ago

panel.on("show",...) is broken in Nightly for SDK versions <= 1.8

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86
macOS

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 766917

People

(Reporter: wbamberg, Unassigned)

References

Details

With a version of the SDK prior to https://github.com/mozilla/addon-sdk/commit/cd13decd45fe6c6c409f8408281e192d76b28bba (the fix for bug 766917), a function listening to panel's "show" event throws an exception like this:

> Error: An exception occurred.
> Traceback (most recent call last):
>   File "resource://jid1-aaix7qsss1kc4g-at-jetpack/addon-kit/lib/panel.js", line 290, in _onShow
>     let textColor = win.getComputedStyle(node).getPropertyValue("color");
> [Exception... "Operation is not supported"  code: "9" nsresult: "0x80530009 (NotSupportedError)"  location: "resource://jid1-aaix7qsss1kc4g-at-jetpack/api-utils/lib/loader.js -> resource://jid1-aaix7qsss1kc4g-at-jetpack/addon-kit/lib/panel.js Line: 290"]

Here's a simple example on the Builder: https://builder.addons.mozilla.org/addon/1060853/latest/
Depends on: 766917
This issue was introduced by following changeset:
  http://hg.mozilla.org/mozilla-central/diff/e983572af03f/toolkit/content/widgets/popup.xml
Changeset related to bug 764755.
It simply changed xul:Panel XBL anonymous DOM content that we were playing with in our Panel module.
Will this be resolved or will add-ons have to be re-built to work again? This is breaking, among other things, 1Password, which makes me sad.
Eric: yes, we may need to ( eventually ) fix this. Also, 1Pass will need to re-pack eventually in order to get this fix. 

A workaround for the time being would be to use Aurora, if possible. We can't track changes in nightly and fix them as they come, we'd end up chasing our own tail.
This issue has been fixed by patch provided in bug 766917.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.