User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:16.0) Gecko/16.0 Firefox/16.0 Build ID: 20120626030539 Steps to reproduce: 1. Press Cmd+N to open a new browser window, then type https://www.mozilla.org/en-US/ in the address bar and press Enter 2. Inspect the element html-element and body-element Actual results: Both of them have a js class Expected results: Only one of them need a js class
Good catch Isac. Looking at at the base template (https://github.com/mozilla/bedrock/blob/master/templates/base.html), we're adding the 'js' class in two places (once of the root element, and once on the body class), as you suggest. It was added to the HTML element in the in-line JS in the base.html and base-resp.html templates, and added to the body in the /media/js/site.js file included in those templates. I've consoloted them and created a pull request. Please review: https://github.com/mozilla/bedrock/pull/207
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Looks good :)
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Commit pushed to dev at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/d3faa2cda2b2a22c213d055c5e6e4efcd05a41a0 Consolodate duplicate 'no-js' class management (Bug 768619)
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.