768798 - The page doesn't bounce back after sliding it

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Attachment: Screenshot

Nightly Fennec 16.0a1 (2012-06-26)
Device: HTC Desire Z 
OS: Android 2.3.3

Steps to Reproduce:
1. Load about:firefox
2. Tap-hold and slide the page until the black background appears.
3. Tap on the page before it bounce back.

Expected:
The page bounce back to the initial position.

Actual:
The page remains slided and the black background is still present.

NOTE: Please see the attached log and screenshot

Comment 1

[Paul Feher]

Attachment: Log file

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Kats does this log look useful?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Unfortunately we took a lot of the logging out of the code so there isn't too much useful in the log. However I can reproduce this locally so I'll take a look.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This is fallout from bug 756474, by the removal of the block of code in TouchEventHandler.dispatchEvent. Before that change, the ACTION_UP event would get sent to the PanZoomController, but now it gets eaten by the mGestureDetector. Note that when the code was originally written (prior to bug 707571 landing), there was no onSingleTapUp method in PanZoomController, so the mGestureDetector would not eat the ACTION_UP event. Bug 707571 added the onSingleTapUp along with the code in TouchEventHandler.dispatchEvent that effectively cancelled it out.

Patch coming shortly.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

The main change needed is to always return false from onSingleTapUp so that it doesn't eat the ACTION_UP event. To make things consistent I also modified onSingleTapConfirmed and onDoubleTap so that they always return true. This is more or less what it used to be like prior to bug 707571, but with the extra allowZoom() guards on the events.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/032188386b9e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/032188386b9e

Comment 8

[Paul Feher]

Verified on:
Nightly Fennec 17.0a1 (2012-08-27)
Device: HTC Desire Z 
OS: Android 2.3.3

Comment 9

[Adrian Tamas (:AdrianT)]

Unable to reproduce the issue on:

Firefox Mobile 16.0b5
HTC Desire Z (Android 2.3.3)

Marking as verified on Firefox Mobile 16.