xplat: debug mode needs to pass '-g' at link time too (at least on Mac OS X).

RESOLVED FIXED

Status

defect
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: pnkfelix, Assigned: pnkfelix)

Tracking

Details

Attachments

(1 attachment)

I spent a little while puzzling over why half of the entries in my avmshell stack traces were missing line number and other symbolic information, which makes debugging a lot less fun.

The answer: in the generated Makefile,

  DEBUG_LDFLAGS=

needs to be

  DEBUG_LDFLAGS=-g
Assignee: nobody → fklockii
Blocks: 724695
Comment on attachment 637199 [details] [diff] [review]
patch A v1: fix it!

(I don't always request code reviews on such trivial patches, but in this case I figure it wouldn't be bad to give Phil a chance to be a reviewer.  I'll post a few more review requests on other bugs for him in the near future I think.)
Attachment #637199 - Flags: review?(mcgachey)

Comment 3

7 years ago
R+ 

Looks good.

Updated

7 years ago
Attachment #637199 - Flags: review?(mcgachey) → review+
Pushed to AVM in CL 1108583.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED

Comment 5

7 years ago
changeset: 7538:73cd54753596
user:      Felix Klock II <fklockii@adobe.com>
summary:   Bug 769005: add -g to link options in debug mode (r=mcgachey).

http://hg.mozilla.org/tamarin-redux/rev/73cd54753596
You need to log in before you can comment on or make changes to this bug.