769005 - xplat: debug mode needs to pass '-g' at link time too (at least on Mac OS X).

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

I spent a little while puzzling over why half of the entries in my avmshell stack traces were missing line number and other symbolic information, which makes debugging a lot less fun.

The answer: in the generated Makefile,

  DEBUG_LDFLAGS=

needs to be

  DEBUG_LDFLAGS=-g

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch A v1: fix it!

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Comment on attachment 637199 [details] [diff] [review]
patch A v1: fix it!

(I don't always request code reviews on such trivial patches, but in this case I figure it wouldn't be bad to give Phil a chance to be a reviewer.  I'll post a few more review requests on other bugs for him in the near future I think.)

Comment 3

[Phil McGachey]

R+ 

Looks good.

Comment 4

[Felix S. Klock II [:pnkfelix, :fklock]]

Pushed to AVM in CL 1108583.

Comment 5

[Tamarin Bot]

changeset: 7538:73cd54753596
user:      Felix Klock II <[e-mail]>
summary:   Bug 769005: add -g to link options in debug mode (r=mcgachey).

http://hg.mozilla.org/tamarin-redux/rev/73cd54753596