769025 - xplat build: fix dependencies that fire off rebuild of shell_toplevel.abc

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Build Config, enhancement)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

This is analogous to Bug 734923.  Most of the work to properly rebuild shell_toplevel.{h,cpp,abc} already landed as part of Bug 734923; the only thing I think I left undone was determining a suitable rule for the shell_toplevel dependencies (which are hard-coded in the shell_toplevel.py file).

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch D v1: enlarge shell_toplevel rebuild deps

This revises the dependencies of shell_toplevel.{h,cpp,abc} to include not just shell/shell_toplevel.as (and the other pair of files that were listed in the dependencies presumably to stop asc from starting off before they were ready), but rather now including *all* of shell/*.as extensions/*.as and shell/shell_toplevel.py.

If I were really slick I'd figure out how to generalize our existing dependency parsing infrastructure to just parse the shell_toplevel.py script.  But i am not that slick.

Comment 2

[Brent Baker]

Comment on attachment 637225 [details] [diff] [review]
patch D v1: enlarge shell_toplevel rebuild deps

Review of attachment 637225 [details] [diff] [review]:
-----------------------------------------------------------------

::: shell/manifest.mk
@@ +116,5 @@
>  
>  # Use of '%' [to force a pattern-rule] instead of '$(curdir)/..' or
>  # '$(topsrcdir)' [which would then not be a pattern-rule] is crucial
>  # (ie "deliberate", ie "hack"); see Bug 632086
> +%/generated/shell_toplevel.h %/generated/shell_toplevel.cpp %/generated/shell_toplevel.abc: $(topsrcdir)/shell_toplevel.py $(topsrcdir)/shell/*.as $(topsrcdir)/core/api-versions.as $(topsrcdir)/extensions/*.as %/generated/builtin.abc

$(topsrcdir)/shell_toplevel.py should be $(topsrcdir)/shell/shell_toplevel.py

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Tamarin is a dead project now. Mass WONTFIX.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Tamarin isn't maintained anymore. WONTFIX remaining bugs.