769037 - Loading Contacts app is slow

Status: RESOLVED DUPLICATE of bug 871823

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Here's the profile:
http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv96ZzvY5KslavR9qViykPVb0SYPtJZ6OpTwKT4xCY4VmKM5X45h4w9Mvyj0n0kBbfu53EZR4pc4XugE6hjmaZoQ-oMNMLxkT9hu7kS56rbZY148qVJm46_b2fm8opoRxk-tkqpceoZ2PdIteRuyF9F49pfLCXg

Things of note:
- I've annotated OfflineCache stuff and it does seem to be responsible for the main thread sqlite io.
- We spend a bunch of time loading hyphenation tables. (Do we need to use hyphenation?)
- We spend time loading and sanitizing fonts
- There's 192 ms of waiting time after the end of the animation

I'm working on annotating some more to get a better picture of where more of the time is spent.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Here's a profile with better annotations:

http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv97E-dvDa9oml46f8y2RRrtClHI0ZnkmSTCEuzV-wkiLQ9V-OmGJuJlvDm25z_h5v7zIq0GsyejkrmSX4G3Yc0Am88HSgwQ0PUL_1cye8BqIivsHmSYZUZtTkvuf8R3Dp6orS3DhvLJPDBI8UEOT8cTg_zvHIg

Comment 2

[Mike Hommey [:glandium]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> Here's a profile with better annotations:
> 
> http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv97E-
> dvDa9oml46f8y2RRrtClHI0ZnkmSTCEuzV-wkiLQ9V-
> OmGJuJlvDm25z_h5v7zIq0GsyejkrmSX4G3Yc0Am88HSgwQ0PUL_1cye8BqIivsHmSYZUZtTkvuf8
> R3Dp6orS3DhvLJPDBI8UEOT8cTg_zvHIg

Where do the annotations appear?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

So, ah, the profile suggests that we're doing offline cache disk IO on the main thread.  Please tell me that's not true.

Comment 4

[Mike Hommey [:glandium]]

I think offline cache is entirely on the main thread.

Comment 5

[Andreas Gal :gal]

All offline cache SQLite IO is sync. FML. Will rewrite today with Thinker.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> > Here's a profile with better annotations:
> > 
> > http://people.mozilla.com/~bgirard/cleopatra/?report=AMIfv97E-
> > dvDa9oml46f8y2RRrtClHI0ZnkmSTCEuzV-wkiLQ9V-
> > OmGJuJlvDm25z_h5v7zIq0GsyejkrmSX4G3Yc0Am88HSgwQ0PUL_1cye8BqIivsHmSYZUZtTkvuf8
> > R3Dp6orS3DhvLJPDBI8UEOT8cTg_zvHIg
> 
> Where do the annotations appear?

A couple of new things are now grouped together. e.g. TextRun construction, hyphenation, css parsing etc.

Comment 7

[Julien Wajsberg [:julienw]]

Should we close this bug now, or make it a meta bug for some more specific bugs (like there still is mozGetAll's lying in the facebook code) ?

Comment 8

[Kevin Grandon :kgrandon]

We're actively working on contacts performance in bug #871823. If you have specific actionable items, please open blockers against that bug. I will make a note of things in this bug and investigate them. Thanks!