769038 - Margin/padding on root element causes selection handles to appear at wrong spot

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:
- Select some text on the page by long tapping on it

Expected result:
- Selection handles appear at the right spot.

Actual result:
- Selection handles appear at the wrong spot.

Comment 1

[Martijn Wargers (dead)]

I suspect this is the cause of the small offset of selection handles at http://mobiel.nu.nl/pda/ (has a 8px margin on the body.

Comment 2

[:Margaret Leibovic]

Attachment: patch

I found margin was the thing causing the problem. 

I was concerned this patch will be wrong if the computed style isn't in pixels, but it seems that getPropertyValue("margin-*") always returns a value in pixels, even if the CSS rule uses a different unit of measure.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f5408e83e0

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a9f5408e83e0

Comment 5

[:Margaret Leibovic]

Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6