769186 - [devtb] Decide on a key sequence for the developer toolbar

Status: RESOLVED FIXED

Description

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Comment 1

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Created attachment 637422 [details] [diff] [review]
v1

This patch reflects what I'd like to do, the correct thing to do is under discussion.

Bug 768150 to pref the toolbar on by default removes the key sequence to avoid a clash with the editor.

Comment 2

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Created attachment 639186 [details] [diff] [review]
v2

We previously removed the key sequence until we could find one that didn't clash. We found ctrl+shift+/

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Joe Walker from comment #2)
> We previously removed the key sequence until we could find one that didn't
> clash. We found ctrl+shift+/

Hmm. At least for German users like me and probably other locales this might be a choice as bad as Panorama's next/prev group shortcut. I need to press shift to reach '/' so this effectively overrides the add-on bar toggle, or doesn't work at all and toggles the add-on bar, not sure.

Comment 4

[Dão Gottwald [::dao]]

Comment on attachment 639186 [details] [diff] [review]
v2

"/" happens to be shift+7 with a German keyboard layout and I think shift+: with a French one, making accel+shift+/ inaccessible. We usually keep command keys consistent across locales, and even if we made an exception, I think we could count on localizers getting this wrong. In this case I don't think we should make an exception anyway, as I don't think it's unreasonable for the keyboard layout to divert from what Firefox locales would expect.

Comment 5

[Dão Gottwald [::dao]]

I'm not sure that we really need a keyboard shortcut for the add-on bar; stealing that might be an option. Ironically, it was added for "users who heavily rely on add-ons for certain task modes (e.g. *web development*)" (bug 616015, emphasis mine).

Comment 6

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Try&rev=d133b4e996e5

Comment 7

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

There aren't good answers to this problem, but I agree that this doesn't work for anyone with a German keyboard.

The developer tools use ctrl+shift/alt+cmd as their modifiers, and there are no free letters without crashing something, I've previously given up on punctuation, for l10n reasons and have done so again, function keys don't work properly on Mac, and numbers are really confusing because we English can't even agree amongst *ourselves* what should be on top of 2. Or 3.

I'm currently trying to work out a way to use ctrl+shift+v (again), and to resolve the conflict with paste-without-formatting in a contenteditable. The UX part of this decision is being done in consultation with shorlander/bdils.

Comment 8

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Created attachment 639493 [details] [diff] [review]
v3

This update does 2 things:
- It changes the key sequence to shift+F2
- It leaves the menu item as a toggle, but makes the keyboard shortcut a 'focus' shortcut, which takes you to the command line even when the toolbar is already open.

Comment 9

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Try&rev=5d7593f205b5

Comment 10

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Bug ping, I'd love to get this into 16 if possible.
Thanks.

Comment 11

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=74218d787b06

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/f942edab3edf