Closed
Bug 769195
Opened 12 years ago
Closed 12 years ago
IonMonkey: TestCommonPropertyFunc() adds overzealous MGuardShape
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: efaust, Assigned: efaust)
Details
Attachments
(1 file)
1.89 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
TestCommonPropertyFunc() keeps track of the shape * that the property was actually found on, and guards on that. This is overzealous. The property is almost certainly not the last one added, so this will bailout more often than necessary.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #637434 -
Flags: review?(jdemooij)
Comment 2•12 years ago
|
||
Comment on attachment 637434 [details] [diff] [review] Fix Review of attachment 637434 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/IonBuilder.cpp @@ +4711,2 @@ > } else if (foundProto != proto) > return true; Nit: single-line "if" now so no longer needs braces.
Attachment #637434 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/projects/ionmonkey/rev/4f57f42dc238 Changed from guarding on the shape we found the property on to the shape of the object.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•