Last Comment Bug 769234 - [devtb] GCLI has focus issues when embedded in firefox
: [devtb] GCLI has focus issues when embedded in firefox
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: P1 normal (vote)
: Firefox 16
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-28 06:09 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-07-05 06:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.56 KB, patch)
2012-06-28 07:10 PDT, Joe Walker [:jwalker] (needinfo me or ping on irc)
dcamp: review+
Details | Diff | Splinter Review

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-06-28 06:09:26 PDT
The output panel should close when the toolbar loses focus

Commands like 'inspect' should not remove focus from the command line when executed.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-06-28 07:10:08 PDT
Created attachment 637505 [details] [diff] [review]
v1
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-06-28 11:14:16 PDT
I was going to fix the focus issue with the inspect command in this bug, however I think the correct solution is different enough that we should do it in a different bug.
I raised bug 769371.

So dcamp - this patch is ready for review.
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-06-29 03:56:02 PDT
https://tbpl.mozilla.org/?tree=Try&rev=c11630ac6eb2
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-04 15:35:02 PDT
https://tbpl.mozilla.org/?tree=Try&rev=59729f63ee39
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-05 00:25:39 PDT
https://tbpl.mozilla.org/?tree=Fx-Team&rev=124c0182df1c
Comment 6 Tim Taubert [:ttaubert] (on PTO, back Aug 29th) 2012-07-05 06:29:42 PDT
https://hg.mozilla.org/mozilla-central/rev/bd74a2949929

Note You need to log in before you can comment on or make changes to this bug.