Closed
Bug 769266
Opened 12 years ago
Closed 1 year ago
Add an option to log to Console when animations can't be asyncified.
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
DUPLICATE
of bug 1121896
People
(Reporter: dzbarsky, Unassigned)
References
Details
Attachments
(1 file, 2 obsolete files)
2.90 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Comment 1•12 years ago
|
||
Please make sure that these notifications are visible through the Web Console.
Reporter | ||
Comment 2•12 years ago
|
||
That's the eventual plan, just need to make sure we don't spam the console too much.
Comment 3•12 years ago
|
||
Can we just add an INFO message for CSS that states:
"Some CSS animations could not be drawn asynchronous, potentially having performance implications: color, -moz-awesome-property, and -moz-awesome-property2."
And only do that when we parse the CSS (instead of printing this each time an animation begins).
Reporter | ||
Updated•12 years ago
|
Summary: tell authors why animation can't be asyncified → Add an option to log when animations can't be asyncified.
Reporter | ||
Comment 4•12 years ago
|
||
Attachment #647582 -
Flags: review?(jones.chris.g)
Reporter | ||
Comment 5•12 years ago
|
||
Attachment #647582 -
Attachment is obsolete: true
Attachment #647582 -
Flags: review?(jones.chris.g)
Attachment #647616 -
Flags: review?(jones.chris.g)
Comment on attachment 647616 [details] [diff] [review]
PAtch
You want to use
nsCOMPtr<nsIConsoleService> consoleService =
do_GetService(NS_CONSOLESERVICE_CONTRACTID);
consoleService->LogStringMessage(msg);
Attachment #647616 -
Flags: review?(jones.chris.g)
Comment 7•12 years ago
|
||
Do we usually get these error messages localized?
Reporter | ||
Comment 8•12 years ago
|
||
Attachment #647616 -
Attachment is obsolete: true
Comment 9•12 years ago
|
||
Er, I guess I should have asked that question of Axel.
Axel, do we usually get web developer-specific console notifications localized?
Comment 10•12 years ago
|
||
Yes, we would localize messages "like this". Please get some help on the actual message, though. I dare say that for people without physical access to your brain, that message isn't helpful. Too much jargon and acronyms. Something like jaws suggested in comment 3 is much more digestible, and quite useful to be localized. You may want to add a localization note on phrases that shouldn't be translated, like CSS keywords, if that makes sense. https://developer.mozilla.org/en/Localization_notes has tips on how to mark those up. Technically, I think we put the strings for code in layout into dom/locales/en-US.
Comment 11•12 years ago
|
||
Can you use an about:config pref for this? I'm not sure how PR_GetEnv works, so maybe it already uses about:config prefs.
Reporter | ||
Updated•12 years ago
|
Summary: Add an option to log when animations can't be asyncified. → Add an option to log to Console when animations can't be asyncified.
Comment 12•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: dzbarsky → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
Updated•1 year ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•