Closed Bug 769266 Opened 12 years ago Closed 1 year ago

Add an option to log to Console when animations can't be asyncified.

Categories

(Core :: Graphics: Layers, defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1121896

People

(Reporter: dzbarsky, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Please make sure that these notifications are visible through the Web Console.
That's the eventual plan, just need to make sure we don't spam the console too much.
Can we just add an INFO message for CSS that states: "Some CSS animations could not be drawn asynchronous, potentially having performance implications: color, -moz-awesome-property, and -moz-awesome-property2." And only do that when we parse the CSS (instead of printing this each time an animation begins).
Summary: tell authors why animation can't be asyncified → Add an option to log when animations can't be asyncified.
Attached patch Patch (obsolete) — Splinter Review
Attachment #647582 - Flags: review?(jones.chris.g)
Attached patch PAtch (obsolete) — Splinter Review
Attachment #647582 - Attachment is obsolete: true
Attachment #647582 - Flags: review?(jones.chris.g)
Attachment #647616 - Flags: review?(jones.chris.g)
Comment on attachment 647616 [details] [diff] [review] PAtch You want to use nsCOMPtr<nsIConsoleService> consoleService = do_GetService(NS_CONSOLESERVICE_CONTRACTID); consoleService->LogStringMessage(msg);
Attachment #647616 - Flags: review?(jones.chris.g)
Do we usually get these error messages localized?
Attachment #647616 - Attachment is obsolete: true
Er, I guess I should have asked that question of Axel. Axel, do we usually get web developer-specific console notifications localized?
Yes, we would localize messages "like this". Please get some help on the actual message, though. I dare say that for people without physical access to your brain, that message isn't helpful. Too much jargon and acronyms. Something like jaws suggested in comment 3 is much more digestible, and quite useful to be localized. You may want to add a localization note on phrases that shouldn't be translated, like CSS keywords, if that makes sense. https://developer.mozilla.org/en/Localization_notes has tips on how to mark those up. Technically, I think we put the strings for code in layout into dom/locales/en-US.
Can you use an about:config pref for this? I'm not sure how PR_GetEnv works, so maybe it already uses about:config prefs.
Summary: Add an option to log when animations can't be asyncified. → Add an option to log to Console when animations can't be asyncified.

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: dzbarsky → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
Status: NEW → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1121896
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: