769312 - [OS.File] Separate OS.File.Error from worker-only code

Status: RESOLVED FIXED

(Core :: Networking: File, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

At the moment, OS.File.Error is tightly coupled with worker-only code. This is not a good idea, as we will want to represent I/O errors also on the main thread.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Note a subtlety:
- the Unix version requires OS.Unix.strerror;
- the Windows version requires OS.Win.FormatMessage, OS.Constants.Win.FORMAT_MESSAGE_FROM_SYSTEM, OS.Constants.Win.FORMAT_MESSAGE_IGNORE_INSERTS.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: 1. Defining libc, OS.File.Error in their own file (Unix).

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: 2. Adapting osfile_* (Unix)

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: 3. Defining libc, OS.File.Error in their own file (Win)

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: 4. Adapting osfile_* (Win)

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Attachment: Companion makefile

Comment 7

[(dormant account)]

Comment on attachment 641871 [details] [diff] [review]
3. Defining libc, OS.File.Error in their own file (Win)

no need to break out separate patches for each file.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Attachment: Shared code

I will take advantage of the opportunity to rename files.

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Unix errors

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Attachment: 2. Adapting osfile_* (Unix)

Comment 11

[David Teller [:Yoric] - still alive but not very active]

Attachment: Windows errors

Comment 12

[David Teller [:Yoric] - still alive but not very active]

Attachment: 4. Adapting osfile_* (Win)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ca5142e757d
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b931642e993
https://hg.mozilla.org/integration/mozilla-inbound/rev/48fb9e5ec22d
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ff952f8a4c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/e255eaa167fa

Should this have tests?

Comment 14

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/3ca5142e757d
https://hg.mozilla.org/mozilla-central/rev/3b931642e993
https://hg.mozilla.org/mozilla-central/rev/48fb9e5ec22d
https://hg.mozilla.org/mozilla-central/rev/8ff952f8a4c7
https://hg.mozilla.org/mozilla-central/rev/e255eaa167fa

Comment 15

[Justin Dolske [:Dolske]]

Small request: please add commit messages with a bit more detail as to function to patches. This landed as:

  David Rajchenbach-Teller — Bug 769312 - Adapt the rest of the code (Windows side).
  David Rajchenbach-Teller — Bug 769312 - Windows errors. r=taras
  David Rajchenbach-Teller — Bug 769312 - Adapt the rest of the code (Unix side).
  David Rajchenbach-Teller — Bug 769312 - Unix errors. r=taras
  David Rajchenbach-Teller — Bug 769312 - Shared code. r=yoric

...which isn't very useful for tree-watching or future file changelog digging. Bug titles are generally enough (and easy!).