Last Comment Bug 769312 - [OS.File] Separate OS.File.Error from worker-only code
: [OS.File] Separate OS.File.Error from worker-only code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: File (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla17
Assigned To: David Rajchenbach-Teller [:Yoric] (please use "needinfo")
:
Mentors:
Depends on: 750178 766194
Blocks: MTOS.File 772187 773643 775950 776258
  Show dependency treegraph
 
Reported: 2012-06-28 09:15 PDT by David Rajchenbach-Teller [:Yoric] (please use "needinfo")
Modified: 2012-10-18 12:31 PDT (History)
4 users (show)
ryanvm: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
1. Defining libc, OS.File.Error in their own file (Unix). (4.21 KB, patch)
2012-07-13 07:21 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
taras.mozilla: review+
Details | Diff | Splinter Review
2. Adapting osfile_* (Unix) (6.89 KB, patch)
2012-07-13 07:23 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
taras.mozilla: review+
Details | Diff | Splinter Review
3. Defining libc, OS.File.Error in their own file (Win) (4.75 KB, patch)
2012-07-13 07:23 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
taras.mozilla: review+
Details | Diff | Splinter Review
4. Adapting osfile_* (Win) (6.62 KB, patch)
2012-07-13 07:24 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
taras.mozilla: review+
Details | Diff | Splinter Review
Companion makefile (1.10 KB, patch)
2012-07-13 07:27 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
no flags Details | Diff | Splinter Review
Shared code (2.33 KB, patch)
2012-07-26 07:00 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
Unix errors (4.57 KB, patch)
2012-07-26 07:01 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
2. Adapting osfile_* (Unix) (9.38 KB, patch)
2012-07-26 07:02 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
Windows errors (5.11 KB, patch)
2012-07-26 07:03 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review
4. Adapting osfile_* (Win) (8.32 KB, patch)
2012-07-26 07:03 PDT, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
dteller: review+
Details | Diff | Splinter Review

Description David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-28 09:15:04 PDT
At the moment, OS.File.Error is tightly coupled with worker-only code. This is not a good idea, as we will want to represent I/O errors also on the main thread.
Comment 1 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-06-28 09:17:24 PDT
Note a subtlety:
- the Unix version requires OS.Unix.strerror;
- the Windows version requires OS.Win.FormatMessage, OS.Constants.Win.FORMAT_MESSAGE_FROM_SYSTEM, OS.Constants.Win.FORMAT_MESSAGE_IGNORE_INSERTS.
Comment 2 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-13 07:21:57 PDT
Created attachment 641868 [details] [diff] [review]
1. Defining libc, OS.File.Error in their own file (Unix).
Comment 3 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-13 07:23:06 PDT
Created attachment 641870 [details] [diff] [review]
2. Adapting osfile_* (Unix)
Comment 4 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-13 07:23:55 PDT
Created attachment 641871 [details] [diff] [review]
3. Defining libc, OS.File.Error in their own file (Win)
Comment 5 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-13 07:24:25 PDT
Created attachment 641872 [details] [diff] [review]
4. Adapting osfile_* (Win)
Comment 6 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-13 07:27:26 PDT
Created attachment 641874 [details] [diff] [review]
Companion makefile
Comment 7 (dormant account) 2012-07-17 13:45:18 PDT
Comment on attachment 641871 [details] [diff] [review]
3. Defining libc, OS.File.Error in their own file (Win)

no need to break out separate patches for each file.
Comment 8 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-26 07:00:48 PDT
Created attachment 646124 [details] [diff] [review]
Shared code

I will take advantage of the opportunity to rename files.
Comment 9 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-26 07:01:36 PDT
Created attachment 646125 [details] [diff] [review]
Unix errors
Comment 10 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-26 07:02:29 PDT
Created attachment 646126 [details] [diff] [review]
2. Adapting osfile_* (Unix)
Comment 11 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-26 07:03:05 PDT
Created attachment 646127 [details] [diff] [review]
Windows errors
Comment 12 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-07-26 07:03:42 PDT
Created attachment 646128 [details] [diff] [review]
4. Adapting osfile_* (Win)
Comment 15 Justin Dolske [:Dolske] 2012-07-27 16:09:48 PDT
Small request: please add commit messages with a bit more detail as to function to patches. This landed as:

  David Rajchenbach-Teller — Bug 769312 - Adapt the rest of the code (Windows side).
  David Rajchenbach-Teller — Bug 769312 - Windows errors. r=taras
  David Rajchenbach-Teller — Bug 769312 - Adapt the rest of the code (Unix side).
  David Rajchenbach-Teller — Bug 769312 - Unix errors. r=taras
  David Rajchenbach-Teller — Bug 769312 - Shared code. r=yoric

...which isn't very useful for tree-watching or future file changelog digging. Bug titles are generally enough (and easy!).

Note You need to log in before you can comment on or make changes to this bug.