Inconsistency between comment and code in nsWindow::Resize

RESOLVED INCOMPLETE

Status

Core Graveyard
Widget: Qt
RESOLVED INCOMPLETE
6 years ago
2 years ago

People

(Reporter: Steven Newbury, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
In widget/qt/nsWindow.cpp:

    // synthesize a resize event if this isn't a toplevel
    if (mIsTopLevel || mListenForResizes) {
        nsIntRect rect(mBounds.x, mBounds.y, aWidth, aHeight);
        nsEventStatus status;
        DispatchResizeEvent(rect, status);
    }

Notice the comment reads "if this isn't a toplevel", yet the code checks for mIsTopLevel.  It's not clear which is correct, but I suspect it's the comment.
Sounds like this was since day 1.1
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/widget/src/gtk2&command=DIFF_FRAMESET&file=nsCommonWidget.cpp&rev2=1.11&rev1=1.10

Chris is it comment wrong or check condition
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

2 years ago
In bug 1282866, I have removed the QT code from the Firefox tree with the approval of the active peer. That code is not currently maintained by any team.

I have looked through the bugs in the Widget: Qt bugzilla component and I believe all of these are no longer relevant because the Qt code has been removed. If you believe that this bug is still valid, please move it to another more appropriate bugzilla component as you reopen it.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.